Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

[BUG] Incorrect UI screenshot on home page #9831

Closed
1 task done
badrivlog opened this issue Nov 24, 2023 · 9 comments · Fixed by #9872
Closed
1 task done

[BUG] Incorrect UI screenshot on home page #9831

badrivlog opened this issue Nov 24, 2023 · 9 comments · Fixed by #9872
Assignees
Labels
🛠 goal: fix undefined 🔢 points: 1 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@badrivlog
Copy link
Contributor

badrivlog commented Nov 24, 2023

Has this bug been raised before?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?

production

Version of BioDrop (for example "v1.2.3")

v2.90.1

Description

After recent changes were made to the project, there is a noticeable discrepancy between the UI screenshot displayed on the home page (search by tags section) and the actual search page UI. The home page (search by tags section) appears to be showing an outdated or incorrect screenshot.

Steps to Reproduce

  1. go to https://www.biodrop.io/
  2. compare the UI screenshot displayed on the home page (search by tags section) with the actual search page UI.

Screenshots

Home page (search by tags section) with incorrect UI screenshot
homepage-incorrect

Actual search page screenshot
search-page-actual

Do you want to work on this issue?

No

If "yes" to above, please explain how you would technically implement this

Edited by @kumarsonsoff3

You need to edit the below screenshot src with the updated one:

"https://user-images.githubusercontent.com/83087385/234587034-baaf983f-1a91-4d2c-b28c-e9f4c9bb9509.png",

@badrivlog badrivlog added 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 🛠 goal: fix undefined labels Nov 24, 2023
Copy link
Contributor

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2023
@EddieHubCommunity EddieHubCommunity unlocked this conversation Nov 26, 2023
@kumarsonsoff3 kumarsonsoff3 added 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) 🔢 points: 1 undefined and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Nov 26, 2023
Copy link
Contributor

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@kumarsonsoff3
Copy link
Member

Good spot, Thank you for raising @badrivlog! 👍

@omkar342
Copy link
Contributor

@kumarsonsoff3, can you assign this to me?

@ArvindParekh
Copy link
Member

Hi, do you think we should work on this after the issue #9828 is solved? That is related to the number badges overlapping with the tags, which leads to tags not being displayed properly.
Working on this after fixing the overlapping issue would mean we have the latest and updated screenshot.

@kumarsonsoff3
Copy link
Member

@ArvindParekh, the issue referenced by you here is being closed as a duplicate to the one which is already resolved. So I think it's good to go with this!

@omkar342 will assign this to you, additionally, check the updated issue description for more info.

@omkar342
Copy link
Contributor

omkar342 commented Nov 30, 2023

Hi @eddiejaoude & @kumarsonsoff3, apart from the above screenshot, I have two more screenshots from our home page, I think that also needs to be changed. Please let me know your view on this.

1)

Home page (your tags) screenshot

old_search_tags_sc

Actual UI screenshot

new_search_tag_sc

2)

Home page (your tags) screenshot

eddie_previous_sc

Actual UI screenshot

eddie_new_sc_2

If you want me to change this also, I am up for this.
Just let me know if I can fix these 3 screenshots under this same issue or not?

@kumarsonsoff3
Copy link
Member

Just let me know if I can fix these 3 screenshots under this same issue or not?

Thanks for noticing those! Yep, you can include all 3 screenshots under this same issue! 👍

--
@omkar342 Please avoid tagging Eddie or any specific maintainers in the comments. They get notifications for every activity on the project, so it just creates extra noise for everyone.

@omkar342
Copy link
Contributor

omkar342 commented Dec 1, 2023

Ok, I will do it.
Sure, I will make sure I do not tag anyone in the comment from next time.
Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛠 goal: fix undefined 🔢 points: 1 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants