Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

[BUG] "Playground" text button is not visible clearly in darkmode #9890

Closed
1 task done
vrushabhgawas14 opened this issue Dec 9, 2023 · 6 comments · Fixed by #9902
Closed
1 task done

[BUG] "Playground" text button is not visible clearly in darkmode #9890

vrushabhgawas14 opened this issue Dec 9, 2023 · 6 comments · Fixed by #9902
Assignees
Labels
🛠 goal: fix undefined 🔢 points: 3 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@vrushabhgawas14
Copy link
Contributor

vrushabhgawas14 commented Dec 9, 2023

Has this bug been raised before?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?

Documentation > Quickstart > Profile with JSON > NOTE (Darkmode)

Version of BioDrop (for example "v1.2.3")

2.95.0

Description

While going through the documentation I found that inside
Documentation > Quickstart > Profile with JSON > NOTE (Darkmode)
the Playground text button is not visible clearly in Darkmode as it has a white color text and its background is aslo light.

Same issue is found at "Quickstart > Profile with Forms >NOTE" where Links text button is not visible clearly.

Edit by Sara Jaoude:

The colour of the links is the same throughout the app - whether this is in an Alert box or not. What has arisen here is that as the Alert box background colour does not change in Dark Mode.

The Alert box needs to change. We would suggest that only in Dark Mode, the Alert box changes to the Alert box text colour and the text in the Alert box changes to the current background colour. New colours should not be needed - we can invert the existing Cours.

Steps to Reproduce

  • Go to : Documentation > Quickstart > Profile with JSON > NOTE (Darkmode) > "Playground text"

  • Go to : Documentation > Quickstart > Profile with Forms > NOTE (Darkmode) > "Links text"

Screenshots

ss

Do you want to work on this issue?

Yes

If "yes" to above, please explain how you would technically implement this

As this will be the first time I will contribute to BioDrop and will give my best.
I don't know what exactly to do but I have figured out that the link text color in darkmode should be change inside
quickstart-json.mdx > Alert > type info with Link.js in darkmode

Edit by Sara Jaoude:

Changes need to be made to the Alert component components/Alert.js

@vrushabhgawas14 vrushabhgawas14 added 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 🛠 goal: fix undefined labels Dec 9, 2023
Copy link
Contributor

github-actions bot commented Dec 9, 2023

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
@SaraJaoude SaraJaoude added 🔢 points: 3 undefined and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Dec 11, 2023
@SaraJaoude
Copy link
Member

@vrushabhgawas14 Thank you for raising and writing a good description. I have assigned this to you - please take a look at the comments I have added in the Description box.

@SaraJaoude SaraJaoude added the 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) label Dec 11, 2023
Copy link
Contributor

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot unlocked this conversation Dec 11, 2023
@vrushabhgawas14
Copy link
Contributor Author

Hello, Ma'am I'm done with issue but just need a confirmation that this color invertion I was suppose to do right?
(In light mode it is same and in Dark mode same colors are inverted.)

changes

@ChinmayMhatre
Copy link
Member

Hello, Ma'am I'm done with issue but just need a confirmation that this color invertion I was suppose to do right? (In light mode it is same and in Dark mode same colors are inverted.)

changes

You can raise a PR and link this issue. You can get feedback from everyone on the PR.

@vrushabhgawas14
Copy link
Contributor Author

vrushabhgawas14 commented Dec 29, 2023

@SaraJaoude Sorry for tagging you ma'am, but I have raised PR 2 weeks ago and I just wanted it to get reviewed.

ℹ️ vrushabhgawas14 has some opened assigned issues: 🔧View assigned issues

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛠 goal: fix undefined 🔢 points: 3 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants