-
-
Notifications
You must be signed in to change notification settings - Fork 4k
[BUG] "Playground" text button is not visible clearly in darkmode #9890
Comments
To reduce notifications, issues are locked until they are
🏁 status: ready for dev
|
@vrushabhgawas14 Thank you for raising and writing a good description. I have assigned this to you - please take a look at the comments I have added in the Description box. |
The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md |
@SaraJaoude Sorry for tagging you ma'am, but I have raised PR 2 weeks ago and I just wanted it to get reviewed. ℹ️ vrushabhgawas14 has some opened assigned issues: 🔧View assigned issues |
Has this bug been raised before?
Where did you find this bug?
Documentation > Quickstart > Profile with JSON > NOTE (Darkmode)
Version of BioDrop (for example "v1.2.3")
2.95.0
Description
While going through the documentation I found that inside
Documentation > Quickstart > Profile with JSON > NOTE (Darkmode)
the
Playground
text button is not visible clearly in Darkmode as it has a white color text and its background is aslo light.Same issue is found at "Quickstart > Profile with Forms >NOTE" where
Links
text button is not visible clearly.Edit by Sara Jaoude:
The colour of the links is the same throughout the app - whether this is in an Alert box or not. What has arisen here is that as the Alert box background colour does not change in Dark Mode.
The Alert box needs to change. We would suggest that only in Dark Mode, the Alert box changes to the Alert box text colour and the text in the Alert box changes to the current background colour. New colours should not be needed - we can invert the existing Cours.
Steps to Reproduce
Go to : Documentation > Quickstart > Profile with JSON > NOTE (Darkmode) > "Playground text"
Go to : Documentation > Quickstart > Profile with Forms > NOTE (Darkmode) > "Links text"
Screenshots
Do you want to work on this issue?
Yes
If "yes" to above, please explain how you would technically implement this
As this will be the first time I will contribute to BioDrop and will give my best.
I don't know what exactly to do but I have figured out that the link text color in darkmode should be change inside
quickstart-json.mdx > Alert > type info with Link.js in darkmode
Edit by Sara Jaoude:
Changes need to be made to the Alert component
components/Alert.js
The text was updated successfully, but these errors were encountered: