Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

fix: improved the .dockerignore #306

Merged
merged 1 commit into from
Oct 18, 2022
Merged

fix: improved the .dockerignore #306

merged 1 commit into from
Oct 18, 2022

Conversation

Pradumnasaraf
Copy link
Contributor

@Pradumnasaraf Pradumnasaraf commented Oct 1, 2022 •
edited by gitpod-io bot
Loading

Fixes Issue

closes #305

Changes proposed

  • Added more elements to .dockerignore to reduce the build size

eddiejaoude
eddiejaoude approved these changes Oct 1, 2022
View reviewed changes
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

gptkrsh
gptkrsh approved these changes Oct 1, 2022
View reviewed changes
Copy link

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Pradumna!

ritikbanger
ritikbanger approved these changes Oct 1, 2022
View reviewed changes
Copy link
Member

@ritikbanger ritikbanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note here: Opening the same issue in other repos and adding the same ignore thing is not consider as a contribution if you are only here for Hacktoberfest.

@Pradumnasaraf
Copy link
Contributor Author

Pradumnasaraf commented Oct 1, 2022 •
edited
Loading

One note here: Opening the same issue in other repos and adding the same ignore thing is not consider as a contribution if you are only here for Hacktoberfest.

Hey, 1st check the file content inside the ignore file in all PR then comment.
Also if anything adds value, I will add 100 repo in Hacktoberfest.

@eddiejaoude eddiejaoude merged commit c8b630a into EddieHubCommunity:main Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gptkrsh gptkrsh gptkrsh approved these changes

@ritikbanger ritikbanger ritikbanger approved these changes

@eddiejaoude eddiejaoude eddiejaoude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OTHER] Improve the .dockerignore file to reduce the build image size
4 participants
@Pradumnasaraf @eddiejaoude @ritikbanger @gptkrsh