Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/Request: timeout when loading XML map #52

Closed
bradmartin opened this issue Nov 1, 2016 · 7 comments
Closed

Enhancement/Request: timeout when loading XML map #52

bradmartin opened this issue Nov 1, 2016 · 7 comments
Assignees
Milestone

Comments

@bradmartin
Copy link
Contributor

The mapbox loading into a view can cause an app to hang for half a second or so. When you declare the map in XML and navigate to the page you have no way to delay that execution so it doesn't cause an interruption to the navigation transition.

A simple solution would be to add a property on the XML view, such as delayMapInit and then accept a value in milliseconds, so then we can make sure the navigation transition has completed before the map constructor is started which isn't the smoothest process. Let me know your thoughts @EddyVerbruggen, you might have a better idea since you know the SDKs better than I for mapbox.

@EddyVerbruggen
Copy link
Collaborator

Great idea!

@EddyVerbruggen
Copy link
Collaborator

Update: got Android behaving nicely locally.

@bradmartin
Copy link
Contributor Author

bradmartin commented Nov 2, 2016

looking forward to it... prepping the app for publish and this is one of the last things on my personal issues 😄

@EddyVerbruggen
Copy link
Collaborator

Can you update the plugin from GitHub (see the last check-in). You get to set a delay property in the XML definition. For instance, delay="500" means the plugin will wait half a second before invoking the Mapbox SDK.

@bradmartin
Copy link
Contributor Author

Yes I'll test this out soon.

On Wed, Nov 2, 2016, 3:53 PM Eddy Verbruggen notifications@github.com
wrote:

Can you update the plugin from GitHub (see the last check-in). You get to
set a delay property in the XML definition. For instance, delay="500"
means the plugin will wait half a second before invoking the Mapbox SDK.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#52 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFulhAH2_tNmRlIPc-0cCRcjXBRAKMb5ks5q6PgzgaJpZM4Kmnls
.

@bradmartin
Copy link
Contributor Author

Good to go 👍

@EddyVerbruggen EddyVerbruggen added this to the 2.2.2 milestone Nov 3, 2016
@EddyVerbruggen
Copy link
Collaborator

Sweet! 2.2.2 is on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants