This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Fix postinstall when nativescript is not in the PATH #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case `nativescript` is not in the PATH variable, trying to execute `nativescript --version` will fail and the rest of the postinstall will not be executed. For example on many test environments, where different CLI versions are tested, CLI is installed in a directory and executed directly from there. Also this breaks adding the plugin with AppBuilder CLI (and other AppBuilder clients). So try-catch the execution.
|
ping @EddyVerbruggen |
|
Hi @rosen-vladimirov, that's a great idea and fix. Thank you! |
EddyVerbruggen
pushed a commit
that referenced
this pull request
Feb 21, 2017
…master file (postinstall.js is generated by webpack from installer.js)
EddyVerbruggen
added a commit
that referenced
this pull request
Apr 18, 2017
Fix postinstall when nativescript is not in the PATH
EddyVerbruggen
added a commit
that referenced
this pull request
Apr 18, 2017
…master file (postinstall.js is generated by webpack from installer.js)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case
nativescriptis not in the PATH variable, trying to executenativescript --versionwill fail and the rest of the postinstall will not be executed.For example on many test environments, where different CLI versions are tested, CLI is installed in a directory and executed directly from there.
Also this breaks adding the plugin with AppBuilder CLI (and other AppBuilder clients).
So try-catch the execution.