This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Skip linking for anonymous users #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix EddyVerbruggen#357 and EddyVerbruggen#389 and maybe others as well. This will avoid the exception `com.google.firebase.auth.FirebaseAuthUserCollisionException: This credential is already associated with a different user account`. This problem occurs if the current user is anonymous, but the `loginResult` points to another already known firebase user (e.g a facebook account). In this case we have to call `firebaseAuth.signInWithCredential(authCredential).addOnCompleteListener(onCompleteListener)` instead of `user.linkWithCredential(authCredential).addOnCompleteListener(onCompleteListener)`
|
Makes sense to me, thank you! |
|
@EddyVerbruggen Great. Thanks for merging! |
|
@EddyVerbruggen Please revert this merge. Explanation on issue #357 |
|
Let me think about this for a bit.. |
EddyVerbruggen
added a commit
that referenced
this pull request
Dec 1, 2017
|
Thanks, @RaphaelJenni and @witi83, for your constructive discussion in #357 👍 I've now reverted this PR and will push 5.0.2 shortly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #357 and #389 and maybe others as well.
This will avoid the exception
com.google.firebase.auth.FirebaseAuthUserCollisionException: This credential is already associated with a different user account.This issue occurs if you call
user.linkWithCredentialon a anonymous user, but theauthCredentialpoints to another already known firebase user (e.g a facebook account). InsteadfirebaseAuth.signInWithCredentialwill be called.