Healing on Selbina - Mhaura boat reduces TP with active signet buff

[pyromaniackeca]

Checklist

• [ x] I have searched for existing issues for issues like this one. The issue has not been posted. (Duplicate reports slow down development.)
• [ x] I have provided reproducable steps. (No "as the title says" posts please. Provide reproducable steps even if it seems like a waste of time.)
• [ x] I have provided my client version in the details. (type /ver into your game window)

Details

Client version: 30181205_0

To reproduce get on the boat from Selbina to Mhaura(or other way around) while having the nation signet buff active. Do a couple of fights to gain TP and /heal. TP will start to reduce by chunks of 100.

I can not confirm or deny that this happens on other boats or airships since I don't have access yet.

[Setz0r]

are ships considered conquest zones?

[Setz0r]

it looks like manaclipper and phanauet channel are, but those are located within the same zone for all docks. the other boats travel between different conquest regions.

[pyromaniackeca]

I wasn't aware of that limitation on the buff, but it makes sense. Should I close the issue?

[Setz0r]

well. this might actually be a bug, i'm researching. apparently signet is supposed to be by "continent" but looking at the code, those zones are skipped because they aren't in regions which means they don't return as being apart of the "signet continent"

leave bug up, i will need to add an exception for those zones

Thank you for reporting!

[pyromaniackeca]

@Setz0r Let me know if there's anything I can do to help. I've been meaning to start familiarizing myself with the code and see if I can find time to contribute.

[Setz0r]

Basically this method needs a little hack in it that checks if the zoneid is any of the ships that travel between the "middle lands" areas.

https://github.com/DarkstarProject/darkstar/blob/a142cd9fe6e85bf8d66f8354e5ed13a7c69685f5/src/map/utils/zoneutils.cpp#L965

[pyromaniackeca]

@Setz0r DarkstarProject/darkstar#6375

Note: I haven't had a chance to setup local env yet to try and test myself. Also not sure how to properly test if this didn't break anything else.

[59blargedy]

resolved in october 10, 2021 update