Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning for xlsx #345

Closed
aloukina opened this issue Jan 28, 2020 · 10 comments
Closed

Deprecation warning for xlsx #345

aloukina opened this issue Jan 28, 2020 · 10 comments
Assignees

Comments

@aloukina
Copy link
Collaborator

We get the following deprecation warning when using xlsx:

python3.7/site-packages/xlrd/xlsx.py:266: PendingDeprecationWarning: This method will be removed in future versions. Use 'tree.iter()' or 'list(tree.iter())' instead.

@mulhod
Copy link
Contributor

mulhod commented Jan 29, 2020

@aloukina Can you point me to a situation where this happens. So far, I don't see it happening anywhere when I run the tests and I don't even see it happening when I open an IPython session and try to use read_excel directly to trigger a warning.

@aloukina
Copy link
Collaborator Author

aloukina commented Jan 30, 2020

@mulhod
[edited since we established that the warnings were not aligned with test names due to parallelization]

@mulhod
Copy link
Contributor

mulhod commented Jan 30, 2020

It's strange. I don't see any warnings when I run the tests. For example:

$ nosetests --nologcapture tests/test_reader.py:TestDataReader.test_add_containers_duplicate_keys
.
----------------------------------------------------------------------
Ran 1 test in 0.156s

OK

@mulhod
Copy link
Contributor

mulhod commented Jan 30, 2020

Would the deprecation warning be expected to show up in the CI build? https://travis-ci.org/EducationalTestingService/rsmtool/jobs/643938322?utm_medium=notification&utm_source=github_status

I don't think I see them there either.

@desilinguist
Copy link
Member

@mulhod are you using the same version of xlrd as @aloukina ?

@mulhod
Copy link
Contributor

mulhod commented Jan 30, 2020

@desilinguist Yes. I am:

$ conda list -p ../rsm_env | grep xlrd
xlrd                      1.2.0                    pypi_0    pypi

@aloukina
Copy link
Collaborator Author

This might be relevant: pandas-dev/pandas#28547

@aloukina
Copy link
Collaborator Author

We are calling read_excel and to_excel, not calling xlrd directly.

@desilinguist
Copy link
Member

yeah, I realized that as soon as I posted and then deleted my message :)

@aloukina
Copy link
Collaborator Author

aloukina commented May 8, 2020

Closing because we are not seeing this warning in tests anymore.

@aloukina aloukina closed this as completed May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants