From c4fc79a6947d58b75ff57e43cf7adbd25fcaba7e Mon Sep 17 00:00:00 2001 From: Eliah Kagan Date: Tue, 24 Oct 2023 00:05:56 -0400 Subject: [PATCH] Remove outdated git_daemon_launched Windows info This removes the Windows-specific information in the warning message in git_daemon_launched. After the associated functionality was updated in #1684 and the warning message was abridged accordingly, the functionality was updated again in #1697, causing the message to be outdated and no longer helpeful (since having git-daemon.exe in a PATH directory is no longer necessary or useful), without any corresponding change to the message. --- test/lib/helper.py | 8 -------- 1 file changed, 8 deletions(-) diff --git a/test/lib/helper.py b/test/lib/helper.py index d415ba2e7..cef6779be 100644 --- a/test/lib/helper.py +++ b/test/lib/helper.py @@ -213,14 +213,6 @@ def git_daemon_launched(base_path, ip, port): and setting the environment variable GIT_PYTHON_TEST_GIT_DAEMON_PORT to """ ) - if is_win: - msg += textwrap.dedent( - R""" - - On Windows, - the `git-daemon.exe` must be in PATH. - For MINGW, look into \Git\mingw64\libexec\git-core\, but problems with paths might appear.""" - ) log.warning(msg, ex, ip, port, base_path, base_path, exc_info=1) yield # OK, assume daemon started manually.