Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom errors in SmartWallet.sol #10

Open
proxima424 opened this issue Oct 18, 2022 · 2 comments
Open

Custom errors in SmartWallet.sol #10

proxima424 opened this issue Oct 18, 2022 · 2 comments
Labels
optimize Optimize contract

Comments

@proxima424
Copy link

I was just wondering if there is a specific reason to not use custom errors here.
If not, can I implement it and raise a PR?
@proxima424
Copy link
Author

@ZhangShengjie

@jayden-sudo
Copy link
Member

jayden-sudo commented Oct 20, 2022 •
edited
Loading

Thank you,it is welcome to submit to branch-upgradable (this is the branch we will use), and the contract is indeed not optimized (currently only the PoC version),
Note: I've been thinking about bundler in the last few days, sorry I didn't see your issue right away, if you want any discuss, you can join our group: https://t.me/+ok9IIpMeXFYwODBl 😃 (of course it is good on github too)

@jayden-sudo jayden-sudo added the optimize Optimize contract label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
optimize Optimize contract
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayden-sudo @proxima424