Improving template usage #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello Dusan, thanks, give me some time for the review. |
|
Now it should be final proposal. With last change the code behave well. |
MichalPrincNXP
approved these changes
Feb 10, 2021
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
|
Hi @MichalPrincNXP i didn't notice your request. Here i even didn't see conflict. But now it should be fine. |
|
Thank you, Dusan for your effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, i was thinking about behave of manually_constracted template in corner cases. I was thinking that destructor and constructor should be able to call only in valid cases. I added one more variable to check if destructor is not called too early or constructor several times.
Not sure if i correctly handled cases like get/operator when class was not constructed. Downside of this solution is one more byte with every object. One byte doesn't sounds too bad, but theoretically we can have macro to turn this feature off. But that doesn't sounds worth it.