Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve python detection #225

Merged

Conversation

Hadatko
Copy link
Member

@Hadatko Hadatko commented Jan 8, 2022

New ubuntu versions doesn't have python. It is replaced with python3. Also 2.x is quite old and obsolete. This PR is fixing it. Not tested on mac.

@Hadatko Hadatko requested a review from MichalPrincNXP January 8, 2022 16:05
@MichalPrincNXP MichalPrincNXP self-assigned this Jan 10, 2022
@Hadatko Hadatko added this to the 1.8.3 milestone Jan 11, 2022
@Hadatko Hadatko assigned Hadatko and unassigned MichalPrincNXP Jan 11, 2022
@MichalPrincNXP
Copy link
Member

New ubuntu versions doesn't have python. It is replaced with python3. Also 2.x is quite old and obsolete. This PR is fixing it. Not tested on mac.

Yes, agree with moving to Python3, PR under testing now, incl. MAC build. Python related doc should be reviewed and updated as needed.

@MichalPrincNXP MichalPrincNXP merged commit c35e59e into EmbeddedRPC:develop Jan 20, 2022
@MichalPrincNXP
Copy link
Member

Tested on MAC as well. Thanks for the effort!

@Hadatko Hadatko deleted the feature/move_to_python3 branch February 4, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants