Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace EXPECT_TRUE with EXPECT_EQ #318

Merged

Conversation

Hadatko
Copy link
Member

@Hadatko Hadatko commented Oct 4, 2022

EXPECT_EQ provide more information in most of cases on fail.

Signed-off-by: Cervenka Dusan cervenka@acrios.com

Pull request

Choose Correct

  • bug
  • feature

Describe the pull request

In case of error EXPECT_EQ is returning detailed information.

To Reproduce

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS:
  • eRPC Version:

Steps you didn't forgot to do

  • I checked if other PR isn't solving this issue.
  • I read Contribution details and did appropriate actions.
  • PR code is tested.
  • PR code is formatted.
  • X] Allow edits from maintainers pull request option is set (recommended).

Additional context

EXPECT_EQ provide more information in most of cases on fail.

Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko Hadatko added this to the 1.10.0 milestone Oct 4, 2022
@Hadatko Hadatko requested a review from MichalPrincNXP October 4, 2022 10:40
@Hadatko Hadatko self-assigned this Oct 4, 2022
@Hadatko
Copy link
Member Author

Hadatko commented Oct 4, 2022

Hi @MichalPrincNXP , this is minor change to tests and ready to merge. In case of error we should see more details in output.

@MichalPrincNXP MichalPrincNXP merged commit 02541cd into EmbeddedRPC:develop Oct 6, 2022
@MichalPrincNXP
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants