Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant includes #338

Merged

Conversation

Hadatko
Copy link
Member

@Hadatko Hadatko commented Jan 12, 2023

Signed-off-by: Cervenka Dusan cervenka@acrios.com

Pull request

Choose Correct

  • bug
  • feature

Describe the pull request

To Reproduce

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS:
  • eRPC Version:

Steps you didn't forgot to do

  • I checked if other PR isn't solving this issue.
  • I read Contribution details and did appropriate actions.
  • PR code is tested.
  • PR code is formatted.
  • Allow edits from maintainers pull request option is set (recommended).

Additional context

Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko Hadatko self-assigned this Jan 12, 2023
@Hadatko
Copy link
Member Author

Hadatko commented Jan 12, 2023

I refactor includes a bit. Is there important position of rpmsg_lite.h include? I can move it to the bottom if yes.

@Hadatko Hadatko added this to the 1.11.0 milestone Jan 12, 2023
Copy link
Member

@MichalPrincNXP MichalPrincNXP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it could be arranged this way, thanks.

@MichalPrincNXP MichalPrincNXP merged commit ae54178 into EmbeddedRPC:develop Jan 27, 2023
@Hadatko Hadatko deleted the feature/refactor_includes branch January 27, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants