Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Adjustment Layers #57

Open
EmilDohne opened this issue Feb 28, 2024 · 1 comment
Open

Add Support for Adjustment Layers #57

EmilDohne opened this issue Feb 28, 2024 · 1 comment
Labels
enhancement New feature or request epic A larger issue that is to be split up into multiple subissues good first issue Good for newcomers help wanted Extra attention is needed LayeredFile Issues pertaining to the LayeredFile struct or usage
Milestone

Comments

@EmilDohne
Copy link
Owner

This is a rather big issue as Photoshop has a wide range of adjustment layers, all with their different implementations and different levels of completeness in the official documentation.

This change would have to be two-fold; adding support for the tagged blocks in the PhotoshopFile under AdditionalLayerInformation and then actually implementing these as an abstraction of Layer<T> in the LayeredFile<T>.

For this issue support would be greatly appreciated as its a rather large issue but at the same time each adjustment layer is its individual separate object. I will attempt to provide a reference implementation once I get started but feel free to contribute!

@EmilDohne EmilDohne added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers LayeredFile Issues pertaining to the LayeredFile struct or usage labels Feb 28, 2024
@EmilDohne EmilDohne added this to the 0.4.0 Release milestone Feb 28, 2024
@EmilDohne EmilDohne added the epic A larger issue that is to be split up into multiple subissues label Jul 12, 2024
@EmilDohne
Copy link
Owner Author

Added support for parsing of a descriptor structure (read only for now) which is the basic building block of most adjustment layers as it supports arbitray key-value data storage similar to json.

What still needs to be done is to more rigorously test this as well as adding access patterns through e.g. a operator[] overload. Once those are done we can add support for writes and start actually implementing the adjustment layers by debugging the structures associated with them via a descriptor based tagged block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request epic A larger issue that is to be split up into multiple subissues good first issue Good for newcomers help wanted Extra attention is needed LayeredFile Issues pertaining to the LayeredFile struct or usage
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant