fix(middlewares): dataversion

fix "cannot find data member 'dataversion' of undefinded"
Enigmatis · Apr 22, 2019 · 27d646a · 27d646a
1 parent 01c03fb
commit 27d646a
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 41 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -114,7 +114,6 @@
     "tslint-consistent-codestyle": "^1.15.1",
     "tslint-eslint-rules": "^5.4.0",
     "tslint-plugin-prettier": "^2.0.1",
-    "typedoc": "^0.14.2",
     "typescript": "3.1.3"
   },
   "peerDependencies": {

diff --git a/src/middlewares/irrelevant-entities-middleware.ts b/src/middlewares/irrelevant-entities-middleware.ts
@@ -11,6 +11,8 @@ export class IrrelevantEntitiesMiddleware implements Middleware {
     postResolve(params: ResponseMiddlewareParams): any {
         if (
             params.result &&
+            params.context &&
+            params.context.headers &&
             params.context.headers.dataVersion &&
             isIrrelevantEntitiesResponse(params.result)
         ) {

diff --git a/src/middlewares/middleware-activation-condition/filter-data-version.ts b/src/middlewares/middleware-activation-condition/filter-data-version.ts
@@ -1,5 +1,4 @@
 import { PolarisContext } from '../../server/polaris-context';
-import { ResponseMiddlewareParams } from '../middleware';
 import { MiddlewareCondition } from './filter-condition';
 
 class FilterDataVersion implements MiddlewareCondition {

diff --git a/test/middlewares/irrelevant-entities-middleware.test.ts b/test/middlewares/irrelevant-entities-middleware.test.ts
@@ -11,14 +11,14 @@ const args = {};
 const irrelevantEntities = ['1234', '2345'];
 const resolverResult = [
     {
-            deleted: false,
-            _id: { id: '5c5bf81a83e6e21ff08710ed' },
-            title: 'zero',
-            author: 'Arik',
-            creationDate: {},
-            lastUpdateDate: {},
-            realityId: 0,
-            dataVersion: 2,
+        deleted: false,
+        _id: { id: '5c5bf81a83e6e21ff08710ed' },
+        title: 'zero',
+        author: 'Arik',
+        creationDate: {},
+        lastUpdateDate: {},
+        realityId: 0,
+        dataVersion: 2,
     },
 ];
 const result = new QueryIrrelevantResult(resolverResult, irrelevantEntities);

diff --git a/tslint.json b/tslint.json
@@ -27,6 +27,9 @@
       "never-prefix"
     ],
     "object-literal-sort-keys": false,
-    "no-implicit-dependencies": [true, "dev"]
+    "no-implicit-dependencies": [
+      true,
+      "dev"
+    ]
   }
 }