Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in large pull requests #235

Closed
333fred opened this issue May 31, 2022 · 2 comments
Closed

Memory leak in large pull requests #235

333fred opened this issue May 31, 2022 · 2 comments
Labels

Comments

@333fred
Copy link

333fred commented May 31, 2022

When I open dotnet/roslyn#61565 or other similarly-sized PRs with this extension enabled, I see memory usage in the tab increase both quickly and regularly, at a rate of ~5 MB/sec (in approximately 5 second bursts), until the tab is eventually killed due to out of memory issues. When I disable Gitako, the leak goes away and the memory usage of the tab is stable.

@EnixCoda EnixCoda added the bug label Jun 1, 2022
@EnixCoda
Copy link
Owner

EnixCoda commented Jun 1, 2022

Thanks, @333fred

After a quick investigation, the reason is that Gitako would query PR file list endlessly because of unexpected responses from GitHub.

I'll release a patch for the issue soon.

@EnixCoda
Copy link
Owner

EnixCoda commented Jun 3, 2022

Fixed in v3.7.1, now Gitako can load PRs even 10x larger than dotnet/roslyn#61565 , e.g. dotnet/roslyn#61070

@EnixCoda EnixCoda closed this as completed Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants