-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation #2
Initial implementation #2
Conversation
@@ -0,0 +1,14 @@ | |||
[package] | |||
name = "eppo" | |||
version = "0.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for now - will bump to 1.0.0
when ready for release. Is that appropriate convention in rust?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, sounds good.
We can release 0.1.x versions until we get feedback from the customers and stabilize API. Once API is stable, we can bump to 1.0.0 and follow semver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to publish this as version 3.0.0 once fully ready to indicate that this version of the SDK is using the UFC
@@ -0,0 +1,23 @@ | |||
name: Cargo Build & Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this right from the beginning. Did you expect this file to run in the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It needs to be merged to affect PRs. So far it runs on my repo: https://github.com/rasendubi/eppo-rust-sdk/actions/runs/8803705195/job/24162446849
Initial implementation of Rust SDK.
This PR is best reviewed by commits.