fix: for common v4.6.2 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerank
commented
Dec 11, 2024
| @@ -597,7 +597,7 @@ export async function precomputedInit( | |||
| throwOnFailedInitialization: true, // always use true here as underlying instance fetch is surrounded by try/catch | |||
| skipInitialPoll: skipInitialRequest, | |||
| }; | |||
| instance.setPrecomputedFlagsRequestParameters(precomputedFlagsRequestParameters); | |||
| instance.setSubjectAndPrecomputedFlagsRequestParameters(precomputedFlagsRequestParameters); | |||
There was a problem hiding this comment.
This is the fix. The new version of common introduces this function that is expected to be used here
felipecsl
approved these changes
Dec 11, 2024
felipecsl
added a commit
that referenced
this pull request
Dec 11, 2024
* feat(events): Allow providing config for DefaultEventDispatcher * write test * fix tests * fix: for common v4.6.2 (#123) * Include subject info in log * Update to setSubjectAndPrecomputedFlagsRequestParameters --------- Co-authored-by: Sameeran Kunche <skunche@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: #issue
Motivation and Context
Description
Need to use the new
setSubjectAndPrecomputedFlagsRequestParametersmethod insteadHow has this been tested?