fix: prevent chrome storage resolving before entries are set

src/cache/chrome-storage-async-map.spec.ts

@@ -0,0 +1,58 @@
+/// <reference types="chrome"/>
+
+import { applicationLogger } from '@eppo/js-client-sdk-common';
+
+import ChromeStorageAsyncMap from './chrome-storage-async-map';
+
+describe('ChromeStorageAsyncMap', () => {
+  const mockStorage = {
+    set: jest.fn(),
+  } as unknown as chrome.storage.StorageArea;
+
+  let storageMap: ChromeStorageAsyncMap<string>;
+
+  beforeEach(() => {
+    jest.clearAllMocks();
+    jest.spyOn(applicationLogger, 'warn').mockImplementation();
+    (mockStorage.set as jest.Mock).mockImplementation(() => Promise.resolve());
+    storageMap = new ChromeStorageAsyncMap(mockStorage);
+  });
+
+  describe('set', () => {
+    it('should store and retrieve values correctly', async () => {
+      const key = 'testKey';
+      const value = 'testValue';
+
+      await storageMap.set(key, value);
+      expect(mockStorage.set).toHaveBeenCalledWith({ [key]: value });
+    });
+
+    it('should propagate storage errors', async () => {
+      const key = 'testKey';
+      const value = 'testValue';
+      const error = new Error('Storage error');
+
+      (mockStorage.set as jest.Mock).mockRejectedValue(error);
+
+      await expect(storageMap.set(key, value)).rejects.toThrow(error);
+      expect(applicationLogger.warn).toHaveBeenCalledWith(
+        'Chrome storage write failed for key:',
+        key,
+        error,
+      );
+    });
+
+    it('should handle multiple keys independently', async () => {
+      const key1 = 'testKey1';
+      const value1 = 'testValue1';
+      const key2 = 'testKey2';
+      const value2 = 'testValue2';
+
+      await storageMap.set(key1, value1);
+      await storageMap.set(key2, value2);
+
+      expect(mockStorage.set).toHaveBeenCalledWith({ [key1]: value1 });
+      expect(mockStorage.set).toHaveBeenCalledWith({ [key2]: value2 });
+    });
+  });
+});

src/cache/chrome-storage-async-map.ts

@@ -1,4 +1,4 @@
-import { AsyncMap } from '@eppo/js-client-sdk-common';
+import { applicationLogger, AsyncMap } from '@eppo/js-client-sdk-common';
 
 /** Chrome storage-backed {@link AsyncMap}. */
 export default class ChromeStorageAsyncMap<T> implements AsyncMap<string, T> {
@@ -18,7 +18,12 @@ export default class ChromeStorageAsyncMap<T> implements AsyncMap<string, T> {
     return await this.storage.get(null);
   }
 
-  async set(key: string, value: T) {
-    await this.storage.set({ [key]: value });
+  async set(key: string, value: T): Promise<void> {
+    try {
+      await this.storage.set({ [key]: value });
+    } catch (error) {
+      applicationLogger.warn('Chrome storage write failed for key:', key, error);
+      throw error;
+    }
   }
 }

src/string-valued.store.ts

@@ -19,13 +19,18 @@ export interface IStringStorageEngine {
  */
 export class StringValuedAsyncStore<T> implements IAsyncStore<T> {
   private initialized = false;
+  private isInitializing = false;
 
   public constructor(private storageEngine: IStringStorageEngine, private cooldownSeconds = 0) {}
 
   public isInitialized(): boolean {
     return this.initialized;
   }
 
+  public isInProcessOfInitializing(): boolean {
+    return this.isInitializing;
+  }
+
   public async isExpired(): Promise<boolean> {
     if (!this.cooldownSeconds) {
       return true;
@@ -47,11 +52,16 @@ export class StringValuedAsyncStore<T> implements IAsyncStore<T> {
   }
 
   public async setEntries(entries: Record<string, T>): Promise<void> {
-    // String-based storage takes a dictionary of key-value string pairs,
-    // so we write the entire configuration and meta to a single location for each.
-    await this.storageEngine.setContentsJsonString(JSON.stringify(entries));
-    const updatedMeta = { lastUpdatedAtMs: new Date().getTime() };
-    await this.storageEngine.setMetaJsonString(JSON.stringify(updatedMeta));
-    this.initialized = true;
+    try {
+      this.isInitializing = true;
+      // String-based storage takes a dictionary of key-value string pairs,
+      // so we write the entire configuration and meta to a single location for each.
+      await this.storageEngine.setContentsJsonString(JSON.stringify(entries));
+      const updatedMeta = { lastUpdatedAtMs: new Date().getTime() };
+      await this.storageEngine.setMetaJsonString(JSON.stringify(updatedMeta));
+      this.initialized = true;
+    } finally {
+      this.isInitializing = false;
+    }
   }
 }