Assignment logging callback #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ploomiz
commented
Jun 23, 2022
| @@ -1,55 +0,0 @@ | |||
| <!--- | |||
There was a problem hiding this comment.
Removed the changelog because prefer to use GitHub releases for release documentation.
petzel
approved these changes
Jun 27, 2022
src/eppo-client.ts
Outdated
| variation: assignedVariation, | ||
| timestamp: new Date().toISOString(), | ||
| subject: subjectKey, | ||
| ...subjectAttributes, |
There was a problem hiding this comment.
Same comment here (from the python SDK review) re: having a separate property for subject attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Motivation and Context
Design Doc: https://www.notion.so/eppo/SDK-Assignment-Logging-7219d14b29cb497d80fa5515de3b229b
Problem: It's not clear when or how to log assignment events with the SDK.
Description
The goal of this PR is to improve assignment logging by 1) providing a standardized assignment event schema and 2) having the SDK determine when or if to log assignments. Consumers pass an
AssignmentLoggerimplementation to the SDK during initialization. The SDK invokes the logger after assigning a subject to a variation. The logger is not invoked if no variation is assigned (for example, because the subject is not part of the sample population).How has this been tested?
Unit tests.