Migrate Node SDK to use V2 Randomization Endpoint #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also reorganize all dtos into /dto folder and suffix filenames with "-dto"
also rename matchesAnyRule => findMatchingRule
vpai
force-pushed
the
varun/rac-v2-updates
branch
from
263eb06 to
b43a832
Compare
ploomiz
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Eppo-exp/eppo#4711
Description
Updated the
getAssignmentlogic to use the allocation (variations + exposure) for the matched targeting rule. The API response inserts a default rule that always matches if the experiment does not have any rules.See linked issue above for further details.
Also made some changes to code organization:
-dtoand grouped them in adtofolder.client.How has this been tested?