This repository has been archived by the owner on Nov 8, 2024. It is now read-only.
[UFC] Use partial instead of full match for regex #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsilv
approved these changes
May 14, 2024
| @@ -143,6 +143,27 @@ def test_evaluate_condition_matches(): | |||
| ) | |||
|
|
|||
|
|
|||
| def test_evaluate_condition_matches_partial(): | |||
| @@ -49,11 +49,11 @@ def evaluate_condition( | |||
| if subject_value is not None: | |||
| if condition.operator == OperatorType.MATCHES: | |||
| return isinstance(condition.value, str) and bool( | |||
| re.match(condition.value, str(subject_value)) | |||
| re.search(condition.value, str(subject_value)) | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Unlike other SDKs, Python currently uses full match search for regex rather than partial match
Description
Switch to using partial match
How has this been tested?
Updated tests and global tests