From 24b23ffb018e1d14129e14f7b4e5782eb469c7d2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tibor=20Cserv=C3=A1k?= Date: Wed, 31 Jul 2024 14:57:54 +0200 Subject: [PATCH] [fix] Minor fixing for statistics tabs The `compare to` filter was turned off for statistics tabs. It is a user request to restore it. Every tabs gets back the filter except checker coverage. Switching between tabs was problematic. When we want to switch from checker coverage to others tab, it triggers a full page refresh. Now, it is fixed. The status of the checkere coverage does not show the number of disabled runs for checkers. With this PR, the user can be informed about the number of runs the checker is off and they can also open the disabled runs modal to list them. --- web/server/codechecker_server/api/report_server.py | 2 +- .../CheckerCoverage/CheckerCoverageStatistics.vue | 6 ------ web/server/vue-cli/src/views/Statistics.vue | 3 ++- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/web/server/codechecker_server/api/report_server.py b/web/server/codechecker_server/api/report_server.py index 6d7b167f69..9d563aca9c 100644 --- a/web/server/codechecker_server/api/report_server.py +++ b/web/server/codechecker_server/api/report_server.py @@ -3072,7 +3072,7 @@ def getCheckerStatusVerificationDetails(self, run_ids, report_filter): checkerName=checker_name, analyzerName=analyzer_name, enabled=[], - disabled=all_run_id, + disabled=all_run_id.copy(), severity=severity, closed=0, outstanding=0 diff --git a/web/server/vue-cli/src/components/Statistics/CheckerCoverage/CheckerCoverageStatistics.vue b/web/server/vue-cli/src/components/Statistics/CheckerCoverage/CheckerCoverageStatistics.vue index 8bf49fca32..dda2d7a5b3 100644 --- a/web/server/vue-cli/src/components/Statistics/CheckerCoverage/CheckerCoverageStatistics.vue +++ b/web/server/vue-cli/src/components/Statistics/CheckerCoverage/CheckerCoverageStatistics.vue @@ -190,12 +190,6 @@ export default { async runIds() { this.noProperRun = false; - }, - - "$route"() { - if (this.runs && this.$route.query.run !== this.actualRunNames) { - this.$router.go(); - } } }, diff --git a/web/server/vue-cli/src/views/Statistics.vue b/web/server/vue-cli/src/views/Statistics.vue index cef90f95a0..d42c1fedc6 100644 --- a/web/server/vue-cli/src/views/Statistics.vue +++ b/web/server/vue-cli/src/views/Statistics.vue @@ -7,7 +7,8 @@ :show-remove-filtered-reports="false" :report-count="reportCount" :show-diff-type="false" - :show-compare-to="false" + :show-compare-to=" + $router.currentRoute.name == 'checker-coverage-statistics'" @refresh="refresh" />