Move marketplace to later version #2262
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbro
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer and
imabdulbasit
as code owners
tbro
force-pushed
the
tb/marketplace/infinate-version
branch
2 times, most recently
from
5edbbac
to
274fbd3
Compare
tbro
changed the title
tbro
force-pushed
the
tb/marketplace/infinate-version
branch
from
274fbd3
to
961c465
Compare
tbro
commented
Nov 6, 2024
| @@ -526,6 +526,8 @@ mod test { | |||
| parent_view_number: u64, | |||
| parent_commitment: VidCommitment, | |||
| ) -> Bundle<SeqTypes> { | |||
| // FIXME error here: | |||
There was a problem hiding this comment.
I believe the 0.3 stated in the error is defined elsewhere? Hotshot or builder api?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2251
Moves
Marketplaceversion out of the way and creates place holderv0_3to hold ProofOfStake upgrade.This PR:
Marketplace is delayed and we need some other upgrades sooner. This will allow us to do that.
This PR does not:
The new
v3doesn't really exist yet. So no logic has been added. It just change the version number ofMarketplaceand a place holder forProofOfStaketo be filled in later.Key places to review:
There are a lot of very small changes spread across many files.
How to test this PR:
I think any errors should be caught by the compiler. That, combined w/ our tests should be good enough IMHO. So if CI is green its probably OK.