Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilinear PCS opening uses too many scalars #170

Closed
chancharles92 opened this issue Dec 20, 2022 · 1 comment · Fixed by #177
Closed

Multilinear PCS opening uses too many scalars #170

chancharles92 opened this issue Dec 20, 2022 · 1 comment · Fixed by #177
Assignees
Labels
enhancement New feature or request

Comments

@chancharles92
Copy link
Contributor

chancharles92 commented Dec 20, 2022

Same issue as in EspressoSystems/hyperplonk#109

The line to be fixed in Jellyfish: https://github.com/EspressoSystems/jellyfish/blob/main/primitives/src/pcs/multilinear_kzg/mod.rs#L357

Note that the existing code is correct but not efficient. The ith quotient polynomial is q(xi, xi+1, ..., xn) that has no variable xi, thus q(0, xi+1, ..., xn) = q(1, xi+1, ..., xn). To have more efficient opening, we only need to set the ith quotient polynomial to be q(xi+1, ..., xn).

@chancharles92 chancharles92 self-assigned this Dec 20, 2022
@chancharles92 chancharles92 changed the title Bugfix: Multilinear PCS opening uses too many scalars Multilinear PCS opening uses too many scalars Dec 21, 2022
@chancharles92 chancharles92 added enhancement New feature or request and removed bug labels Dec 21, 2022
@chancharles92
Copy link
Contributor Author

chancharles92 commented Jan 5, 2023

Referenced PR: EspressoSystems/hyperplonk#113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant