Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

Which JSAPI FeatureLayer methods should be supported in esriFeatureLayer? #100

Closed
3 tasks done
jwasilgeo opened this issue Sep 16, 2015 · 3 comments
Closed
3 tasks done

Comments

@jwasilgeo
Copy link
Contributor

Stemming from issue #97, which JSAPI FeatureLayer methods should be supported in esriFeatureLayer? If it doesn't overstep the goals of this repo in terms of adding on a bunch of new layer functionality, it might be nice to include a few that are commonly used.

setters

  • setDefinitionExpression()
  • setOpacity()
  • setVisibility()
  • [ ] setRenderer()

getters

  • ?

other

  • ?

Would be worthwhile to look over PR #68 to see if anything happens to overlap. At a quick glance, I don't think it will much, but the symbols or renderers might later.

@tomwayson
Copy link
Member

Generally speaking I'm not in favor of proactively expanding the footprint right now. I'd prefer requests to come in from the community.

That said, definition expression and opacity are on par w/ visibility in terms of usefulness and difficulty. I'd say we want to include them by v1.0.

Setting renderers would also be very useful, but it's a can 'o' worms that I don't want to open at this time.

@jwasilgeo
Copy link
Contributor Author

@tomwayson, awesome, I think we're on the same page here. Once we were discussing visibility and definitionExpression, opacity crossed my mind as being similar and commonly used. After that, I just wanted to 2x check there wasn't anything else within-scope or obvious I was missing that could be vetted in a central place. 😃 Thanks.

@tomwayson
Copy link
Member

Yeah, opacity should be an easy win. Good idea. It also would demonstrate two way binding to a decimal value, rounding out the trifecta with the others ones being boolean and string.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants