Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

Move core services (esriLoader) to own module ('esri.core')? #69

Closed
tomwayson opened this issue Aug 18, 2015 · 2 comments
Closed

Move core services (esriLoader) to own module ('esri.core')? #69

tomwayson opened this issue Aug 18, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@tomwayson
Copy link
Member

I want to enable the "roll your own custom map directive" pattern (as demonstrated in https://github.com/tomwayson/angular-parcel-map), as this will make it easier to spin up gists/fiddles/repos that demonstrate how to use newer angular 1.x patterns (controllerAs, bindToController, using a module loader like browserify, and ES6) that help prepare for 2.0.

At the same the community is continuing to build out the declarative mapping directives here. I want to encourage that w/o causing those that just need the esriLoader for their own custom directive to have to deal w/ the increasing complexity and versions that come w/ all those community contributions.

I'm thinking the "core" is pretty much just the esriLoader at this point. That could be made into it's own angular module ("esri.core") and the "esri.map" module could declare that as a dependency.

Thoughts? Feelings?

@tomwayson tomwayson changed the title Move services (esriLoader) to own module ('esri.core')? Move core services (esriLoader) to own module ('esri.core')? Aug 18, 2015
@tomwayson tomwayson modified the milestone: Beta 5 Aug 18, 2015
@jwasilgeo
Copy link
Contributor

@tomwayson I think that's a great idea. I find that when I "roll" my own map directives, I end up pulling in all of esri.map module when I really just want the functionality of esriLoader as well as esriRegistry. For example, see here at lines 17 & 19 (note: this example is pre-PR #60).

Any other thoughts from you or the community? I say let's do this!

@tomwayson
Copy link
Member Author

resolved by #135

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants