Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processParams not converting extent to string #1023

Closed
benstoltz opened this issue Sep 20, 2022 · 2 comments
Closed

processParams not converting extent to string #1023

benstoltz opened this issue Sep 20, 2022 · 2 comments
Assignees
Labels

Comments

@benstoltz
Copy link
Member

Describe the bug

addItem and updateItem both expect extent to be a flattened string instead of a bbox ( 1, 2, 3, 4 vs [[1, 2], [3, 4]] ). Apparently around two years ago we made a change to processParams ( #779 ) for catalog to allow array of arrays through. At that time it was decided to do that for all the cases so as to not make an explicit reference to a property. Unfortunately that has broken extent. What ends up happening is in the actual request the bbox is split into two different extent params, the create/update call succeeds, however the item ends up with an extent which is simply an empty array.

Reproduction

Will be provided

Logs

No response

System Info

v3.4.3

Additional Information

No response

@dbouwman
Copy link
Member

@benstoltz please implement the conversion from number[][] to string in the createItem and updateItem functions, and leave the processParams function as-is

@gavinr
Copy link
Contributor

gavinr commented Oct 17, 2022

Closing per @dbouwman.

@gavinr gavinr closed this as completed Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants