Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus issue while calcite-popover is used from the calcite-dialog component. #10999

Closed
2 of 6 tasks
sid12777 opened this issue Dec 5, 2024 · 1 comment
Closed
2 of 6 tasks
Labels
0 - new New issues that need assignment. ArcGIS AppStudio Issues logged by ArcGIS AppStudio team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.

Comments

@sid12777
Copy link

sid12777 commented Dec 5, 2024

Check existing issues

Actual Behavior

Modelbuilder have a custom dialog html element which we were using to show tool dialog. With the rollout of new calcite-dialog component, I am trying to upgrade the component by using the calcite-dialog component instead of html dialog component.

Focus-issue-calcite-dialog.mp4

I am seeing this issue of focus being trapped in calcite-dialog when I am trying to open a calcite-popover from the calcite-dialog. The focus from calcite-dialog close button is not able to shift to popover close button. Might be due to multiple trappable components.

I also noticed that if a popover is open from the calcite-dialog, and when close button is clicked on popover, there is a console error related to the focus.

image

Here is the code pen of the above problem. https://codepen.io/mac_and_cheese/pen/WberzdQ?editors=1000

Machine details:
Windows 11,
Chrome version: Version 131.0.6778.108 (Official Build) (64-bit)
calcite-components: 2.14.0-next.20

Expected Behavior

There should be no errors in the console, and focus should transfer to the components.

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/WberzdQ?editors=1000

Reproduction Steps

  1. Open the console for the browser.
  2. Click on the info icon and then click on the popover close button.
  3. We can see the error in the console.

Reproduction Version

2.14.0-next.20

Relevant Info

Machine details:
Windows 11,
Chrome version: Version 131.0.6778.108 (Official Build) (64-bit)
calcite-components: 2.14.0-next.20

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS AppStudio

@sid12777 sid12777 added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Dec 5, 2024
@github-actions github-actions bot added ArcGIS AppStudio Issues logged by ArcGIS AppStudio team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Dec 5, 2024
@geospatialem
Copy link
Member

geospatialem commented Dec 20, 2024

Closing as this has been mitigated as of 3.0.0-next.76. Calcite will also be working towards adopting the focusTrapDisabled property with #10685 in early 2025, targeted for 25.R2.

@geospatialem geospatialem closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS AppStudio Issues logged by ArcGIS AppStudio team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

2 participants