Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tree): parent item behavior of single, children, and multichildren selection modes #6971

Closed
SkyeSeitz opened this issue May 17, 2023 · 5 comments
Closed

fix(tree): parent item behavior of single, children, and multichildren selection modes #6971

SkyeSeitz opened this issue May 17, 2023 · 5 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-tree Issues that pertain to the calcite-tree and related components Calcite (design) Issues logged by Calcite designers. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2023 September Pr...

Comments

@SkyeSeitz
Copy link

SkyeSeitz commented May 17, 2023 •
edited
Loading

Actual Behavior

There are a few additional bug fixes needed on the recent adjustments to Tree's selection of parent category w/out selecting children #6926

  1. Hit target to expand parent Tree Item does not include icon + text area
  2. Parent Tree Items with decedents are selectable in single, children, and childrenmulti selection modes

Expected Behavior

  1. Hit target to expand parent Tree Item includes icon + text area
  2. Parent Tree Items with decedents are not selectable in single, children, and multichildren selection modes

NONE
SINGLE
MULTI
CHILDREN
MULTICHILDREN

link to mock ups

Reproduction Sample

https://esri.github.io/calcite-components/?path=/story/components-tree--simple&knob-checked=true&knob-disabled=true&knob-filterEnabled=true&knob-intl-deselect=Deselect&knob-intl-loading=Loading&knob-intl-select=Select&knob-label=Checkbox&knob-loading=true&knob-scale=m&knob-selectable=true&knob-selected=true&knob-thumbnail-position=block-start

Reproduction Steps

Open Tree samples in Story book and click on parents of the mentioned selection modes.

Reproduction Version

v1.3.1

Relevant Info

Related Issues: #6912, #6444, #6509

Regression?

No response

Priority impact

p2 - want for current milestone

Impact

Resolving this bug fix will allow us to move forward on related enhancements & bug fixes to List #6544

Esri team

Calcite (design)
@SkyeSeitz SkyeSeitz added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels May 17, 2023
@github-actions github-actions bot added the Calcite (design) Issues logged by Calcite designers. label May 17, 2023
@SkyeSeitz
Copy link
Author

cc @geospatialem @ashetland

@geospatialem geospatialem added the c-tree Issues that pertain to the calcite-tree and related components label May 17, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label May 17, 2023
@brittneytewks brittneytewks added estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library labels May 25, 2023
@geospatialem geospatialem added estimate - 5 A few days of work, definitely requires updates to tests. research Issues that require more in-depth research or multiple team members to resolve or make decision. and removed estimate - 3 A day or two of work, likely requires updates to tests. labels Jul 24, 2023
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jul 24, 2023
@geospatialem
Copy link
Member

Research will be conducted to determine time estimate for future milestone assignment.

@ashetland
Copy link

Behaviors should also match designs in issue #6544 for List

@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Sep 19, 2023
@jcfranco jcfranco mentioned this issue Sep 20, 2023
Merged
@jcfranco jcfranco mentioned this issue Sep 28, 2023
Merged
jcfranco added a commit that referenced this issue Sep 29, 2023
@jcfranco
fix(tree): update tree selection per design spec (#7852)
06b3594 
**Related Issue:** #6971 

## Summary

* toggle non-selectable parents when clicked w/o affecting selection
(`multiple`, `none`, `single`, `single-persist`)
* update selection color & text weight (`children`, `multichildren`)
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed research Issues that require more in-depth research or multiple team members to resolve or make decision. 2 - in development Issues that are actively being worked on. labels Sep 29, 2023
@github-actions github-actions bot assigned geospatialem and unassigned jcfranco Sep 29, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 2, 2023
@geospatialem
Copy link
Member

Verified behavior mentioned in #6971 (comment) for all selectionMode types in 1.9.0-next.16.

@jcfranco jcfranco mentioned this issue Oct 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-tree Issues that pertain to the calcite-tree and related components Calcite (design) Issues logged by Calcite designers. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2023 September Priorities - Main release
Development

No branches or pull requests
5 participants
@jcfranco @geospatialem @SkyeSeitz @ashetland @brittneytewks