Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New build errors in Gatsby and SvelteKit sample apps #9909

Closed
2 of 6 tasks
benelan opened this issue Jul 30, 2024 · 2 comments
Closed
2 of 6 tasks

New build errors in Gatsby and SvelteKit sample apps #9909

benelan opened this issue Jul 30, 2024 · 2 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality

Comments

@benelan
Copy link
Member

benelan commented Jul 30, 2024

Check existing issues

Actual Behavior

Some new build errors in SSR apps were introduced due to #9650.

Expected Behavior

No new build errors in SSR apps

Reproduction Sample

https://github.com/noahmulfinger/gatsby-calcite-components

Reproduction Steps

  1. Clone the repro sample above from Error during SSR #9242
  2. Run: npm install @esri/calcite-components@v2.11.0-next.0
  3. Run: npm run build
  4. Notice the errors
  5. Run: npm install @esri/calcite-components@v2.10.2-next.2
  6. Repeat step 3
  7. Notice there are different errors, which I resolved in fix: improve browser check to resolve SSR errors #9897

Reproduction Version

@esri/calcite-components@v2.11.0-next.0

Relevant Info

The build errors you'll see from the repro steps:

failed Building production JavaScript and CSS bundles - 10.978s

 ERROR #98124  WEBPACK.BUILD-JAVASCRIPT

Generating JavaScript bundles failed

undefined

If you're trying to use a package make sure that 'undefined' is installed. If you're trying to use a local file make sure that the path is correct.

File: node_modules/@esri/calcite-components/dist/components/ExpandToggle.js:6:0

The error above is repeated all (I think?) of the files in dist/components.


The SvelteKit repro sample also has build errors:

✘ [ERROR] Missing "./internal/client/index.js" specifier in "@stencil/core" package [plugin vite:dep-pre-bundle]

    node_modules/@esri/calcite-components/dist/components/index.js:8:73:
      8 │ export { getAssetPath, setAssetPath, setNonce, setPlatformOptions } from '@stencil/core/internal/client/index.js';
        ╵                                                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  This error came from the "onResolve" callback registered here:

    node_modules/esbuild/lib/main.js:1150:20:
      1150 │       let promise = setup({
           ╵                     ^

    at setup (file:///****/calcite-design-system-ssr-repro-9242/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:47463:13)
    at handlePlugins (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:1150:21)
    at buildOrContextImpl (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:873:5)
    at Object.buildOrContext (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:699:5)
    at /****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:2032:68
    at new Promise (<anonymous>)
    at Object.context (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:2032:27)
    at Object.context (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:1874:58)
    at prepareEsbuildOptimizerRun (file:///****/calcite-design-system-ssr-repro-9242/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:51405:33)

✘ [ERROR] Missing "./internal/client/index.js" specifier in "@stencil/core" package [plugin vite:dep-pre-bundle]

    node_modules/@esri/calcite-components/dist/components/button.js:6:71:
      6 │ import { proxyCustomElement, HTMLElement, forceUpdate, Build, h } from '@stencil/core/internal/client/index.js';
        ╵                                                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  This error came from the "onResolve" callback registered here:

    node_modules/esbuild/lib/main.js:1150:20:
      1150 │       let promise = setup({
           ╵                     ^

    at setup (file:///****/calcite-design-system-ssr-repro-9242/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:47463:13)
    at handlePlugins (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:1150:21)
    at buildOrContextImpl (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:873:5)
    at Object.buildOrContext (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:699:5)
    at /****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:2032:68
    at new Promise (<anonymous>)
    at Object.context (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:2032:27)
    at Object.context (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:1874:58)
    at prepareEsbuildOptimizerRun (file:///****/calcite-design-system-ssr-repro-9242/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:51405:33)

✘ [ERROR] Missing "./internal/client/index.js" specifier in "@stencil/core" package [plugin vite:dep-pre-bundle]

    node_modules/@esri/calcite-components/dist/components/loadable.js:6:35:
      6 │ import { Build, forceUpdate } from '@stencil/core/internal/client/index.js';
        ╵                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  This error came from the "onResolve" callback registered here:

    node_modules/esbuild/lib/main.js:1150:20:
      1150 │       let promise = setup({
           ╵                     ^

    at setup (file:///****/calcite-design-system-ssr-repro-9242/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:47463:13)
    at handlePlugins (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:1150:21)
    at buildOrContextImpl (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:873:5)
    at Object.buildOrContext (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:699:5)
    at /****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:2032:68
    at new Promise (<anonymous>)
    at Object.context (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:2032:27)
    at Object.context (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:1874:58)
    at prepareEsbuildOptimizerRun (file:///****/calcite-design-system-ssr-repro-9242/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:51405:33)

✘ [ERROR] Missing "./internal/client/index.js" specifier in "@stencil/core" package [plugin vite:dep-pre-bundle]

    node_modules/@esri/calcite-components/dist/components/loader.js:6:57:
      6 │ import { proxyCustomElement, HTMLElement, h, Host } from '@stencil/core/internal/client/index.js';
        ╵                                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  This error came from the "onResolve" callback registered here:

    node_modules/esbuild/lib/main.js:1150:20:
      1150 │       let promise = setup({
           ╵                     ^

    at setup (file:///****/calcite-design-system-ssr-repro-9242/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:47463:13)
    at handlePlugins (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:1150:21)
    at buildOrContextImpl (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:873:5)
    at Object.buildOrContext (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:699:5)
    at /****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:2032:68
    at new Promise (<anonymous>)
    at Object.context (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:2032:27)
    at Object.context (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:1874:58)
    at prepareEsbuildOptimizerRun (file:///****/calcite-design-system-ssr-repro-9242/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:51405:33)

✘ [ERROR] Missing "./internal/client/index.js" specifier in "@stencil/core" package [plugin vite:dep-pre-bundle]

    node_modules/@esri/calcite-components/dist/components/icon.js:6:78:
      6 │ import { getAssetPath, proxyCustomElement, HTMLElement, h, Host, Build } from '@stencil/core/internal/client/index.js';
        ╵                                                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  This error came from the "onResolve" callback registered here:

    node_modules/esbuild/lib/main.js:1150:20:
      1150 │       let promise = setup({
           ╵                     ^

    at setup (file:///****/calcite-design-system-ssr-repro-9242/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:47463:13)
    at handlePlugins (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:1150:21)
    at buildOrContextImpl (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:873:5)
    at Object.buildOrContext (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:699:5)
    at /****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:2032:68
    at new Promise (<anonymous>)
    at Object.context (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:2032:27)
    at Object.context (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:1874:58)
    at prepareEsbuildOptimizerRun (file:///****/calcite-design-system-ssr-repro-9242/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:51405:33)

✘ [ERROR] Missing "./internal/client/index.js" specifier in "@stencil/core" package [plugin vite:dep-pre-bundle]

    node_modules/@esri/calcite-components/dist/components/observers.js:6:22:
      6 │ import { Build } from '@stencil/core/internal/client/index.js';
        ╵                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  This error came from the "onResolve" callback registered here:

    node_modules/esbuild/lib/main.js:1150:20:
      1150 │       let promise = setup({
           ╵                     ^

    at setup (file:///****/calcite-design-system-ssr-repro-9242/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:47463:13)
    at handlePlugins (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:1150:21)
    at buildOrContextImpl (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:873:5)
    at Object.buildOrContext (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:699:5)
    at /****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:2032:68
    at new Promise (<anonymous>)
    at Object.context (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:2032:27)
    at Object.context (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:1874:58)
    at prepareEsbuildOptimizerRun (file:///****/calcite-design-system-ssr-repro-9242/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:51405:33)

✘ [ERROR] Missing "./internal/client/index.js" specifier in "@stencil/core" package [plugin vite:dep-pre-bundle]

    node_modules/@esri/calcite-components/dist/components/interactive.js:6:25:
      6 │ import { Build, h } from '@stencil/core/internal/client/index.js';
        ╵                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  This error came from the "onResolve" callback registered here:

    node_modules/esbuild/lib/main.js:1150:20:
      1150 │       let promise = setup({
           ╵                     ^

    at setup (file:///****/calcite-design-system-ssr-repro-9242/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:47463:13)
    at handlePlugins (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:1150:21)
    at buildOrContextImpl (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:873:5)
    at Object.buildOrContext (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:699:5)
    at /****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:2032:68
    at new Promise (<anonymous>)
    at Object.context (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:2032:27)
    at Object.context (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:1874:58)
    at prepareEsbuildOptimizerRun (file:///****/calcite-design-system-ssr-repro-9242/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:51405:33)

✘ [ERROR] Missing "./internal/client/index.js" specifier in "@stencil/core" package [plugin vite:dep-pre-bundle]

    node_modules/@esri/calcite-components/dist/components/form.js:6:18:
      6 │ import { h } from '@stencil/core/internal/client/index.js';
        ╵                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  This error came from the "onResolve" callback registered here:

    node_modules/esbuild/lib/main.js:1150:20:
      1150 │       let promise = setup({
           ╵                     ^

    at setup (file:///****/calcite-design-system-ssr-repro-9242/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:47463:13)
    at handlePlugins (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:1150:21)
    at buildOrContextImpl (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:873:5)
    at Object.buildOrContext (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:699:5)
    at /****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:2032:68
    at new Promise (<anonymous>)
    at Object.context (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:2032:27)
    at Object.context (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:1874:58)
    at prepareEsbuildOptimizerRun (file:///****/calcite-design-system-ssr-repro-9242/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:51405:33)

✘ [ERROR] Missing "./internal/client/index.js" specifier in "@stencil/core" package [plugin vite:dep-pre-bundle]

    node_modules/@esri/calcite-components/dist/components/t9n.js:6:36:
      6 │ import { Build, getAssetPath } from '@stencil/core/internal/client/index.js';
        ╵                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  This error came from the "onResolve" callback registered here:

    node_modules/esbuild/lib/main.js:1150:20:
      1150 │       let promise = setup({
           ╵                     ^

    at setup (file:///****/calcite-design-system-ssr-repro-9242/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:47463:13)
    at handlePlugins (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:1150:21)
    at buildOrContextImpl (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:873:5)
    at Object.buildOrContext (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:699:5)
    at /****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:2032:68
    at new Promise (<anonymous>)
    at Object.context (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:2032:27)
    at Object.context (/****/calcite-design-system-ssr-repro-9242/node_modules/esbuild/lib/main.js:1874:58)
    at prepareEsbuildOptimizerRun (file:///****/calcite-design-system-ssr-repro-9242/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:51405:33)

Regression?

@esri/calcite-components@v2.10.2-next.2

Priority impact

impact - p1 - need for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)

@benelan benelan added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 30, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Jul 30, 2024
@benelan benelan added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 30, 2024
@benelan benelan self-assigned this Jul 30, 2024
@geospatialem geospatialem added this to the 2024-07-30 - Jul Release milestone Jul 30, 2024
@geospatialem geospatialem added estimate - 2 Small fix or update, may require updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality labels Jul 30, 2024
@benelan benelan added skip visual snapshots Pull requests that do not need visual regression testing. and removed skip visual snapshots Pull requests that do not need visual regression testing. labels Jul 30, 2024
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 31, 2024
Copy link
Contributor

Installed and assigned for verification.

@jcfranco
Copy link
Member

Verified locally. 🚀

@jcfranco jcfranco added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 31, 2024
@jcfranco jcfranco assigned jcfranco and unassigned geospatialem and DitwanP Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Development

No branches or pull requests

4 participants