Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imported version of esri-leaflet to 3.0.2 #272

Closed
jon571 opened this issue Jul 6, 2021 · 6 comments
Closed

Update imported version of esri-leaflet to 3.0.2 #272

jon571 opened this issue Jul 6, 2021 · 6 comments

Comments

@jon571
Copy link

jon571 commented Jul 6, 2021

Esri-leaflet recently made a change here:
Esri/esri-leaflet@a6a46fc

This is to stop an error issued by webpack 5, in my case after upgrading to angular 12:
./node_modules/esri-leaflet-geocoder/node_modules/esri-leaflet/src/EsriLeaflet.js:2:0-51 - Error: Should not import the named export 'version' (reexported as 'VERSION') from default-exporting module (only default export is available soon)

@gavinr
Copy link
Contributor

gavinr commented Jul 7, 2021

I think you can do this yourself - just run:

npm install
npm install esri-leaflet@3.0.2

@jgravois
Copy link
Contributor

jgravois commented Jul 7, 2021

you can, but 3x is outside the SemVer range defined in the package.json
https://github.com/Esri/esri-leaflet-geocoder/blob/master/package.json#L13

@gavinr
Copy link
Contributor

gavinr commented Jul 7, 2021

Ah, good point. I suppose we should have included that ("esri-leaflet": "^3.0.0") in v3.0 release.

@jgravois
Copy link
Contributor

jgravois commented Jul 7, 2021

meh. live and learn! 😸

@jon571
Copy link
Author

jon571 commented Jul 8, 2021

Any idea when there might be a release available on npm for this?

Cheers :-)

@gavinr
Copy link
Contributor

gavinr commented Jul 20, 2021

This was released in v3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants