Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

Using Pro 2.3, some of the 2525D Source SVGs are failing to import into Pro Styles #284

Closed
topowright-zz opened this issue Aug 28, 2018 · 4 comments

Comments

@topowright-zz
Copy link
Contributor

From @csmoore on July 16, 2018 18:11

Summary of Issue Encountered:

Starting at Pro 2.2, some of the 2525D Source SVGs are failing to import into Pro Mobile Styles. The failing SVGs seems to have empty Path elements.

Brief summary of issue encountered:

After installing Pro 2.2 and attempting to load the following SVGs from:
https://github.com/Esri/military-features-data/tree/dev/military-symbology-styles/utils-and-source-data/svg

svg\Appendices\Space\05120400.svg
svg\Appendices\Land\20120201.svg
svg\Appendices\Activities\40131202_0.svg
svg\Appendices\Activities\40131202_1.svg
svg\Appendices\Activities\40131202_2.svg
svg\Appendices\Activities\40131202_3.svg
svg\Appendices\Atmospheric\45162101.svg
svg\Legacy\2525C\S-G-UCDMM-_2.svg
svg\Legacy\2525C\S-G-UUMSEJ_0.svg
svg\Legacy\2525C\S-G-UUMSEJ_1.svg
svg\Legacy\2525C\S-G-UUMSEJ_2.svg
svg\Legacy\2525C\S-G-UUMSEJ_3.svg

A failure is encountered:

image

Describe the product and version used:

Pro 2.2

Reproduction Steps and/or Where to Obtain Test Data:

Step-by-step description of how to reproduce the issue and the expected results:

  1. Create or use and exiting Pro Mobile Style
  2. Create a new symbol in the style
  3. Click on the layer properties for the new symbols and
  4. Load a Shape Marker from file using one of the files above, ex:
    https://github.com/Esri/military-features-data/tree/dev/military-symbology-styles/utils-and-source-data/svg/Appendices/Space/05120400.svg

You receive an error:

image

Additional information or sample data:

If you look at the failing symbols in an SVG Editor you can see that failing elements/artifacts - these are indeed empty/spurious path elements, but it would be best if Pro could just ignore these. Otherwise we should fix the source symbols to remove these paths (Note: the symbol do import fine if you remove these spurious elements).

image

image

Just to summarize this requires a fix in either:

  1. Pro to ignore these elements -or-
  2. The SVGs to remove these unused/bad paths

FYI @ACueva @dfoll @lfunkhouser @topowright

Copied from original issue: Esri/military-features-data#334

@lfunkhouser
Copy link
Member

@BobBooth Please take a look at what it would take to fix the SVGs (@csmoore option 2 in the previous comment).

@BobBooth
Copy link
Contributor

@lfunkhouser - If it is just the SVGs listed above, it should not be much effort to delete the empty path elements. I see that they show up in the layer lists, and can be deleted from there.

@jeconley
Copy link

Some of these have been fixed in Pro 2.2. You will no longer see the loading error for any of the SVGs.
I believe these ones are now correct:
svg\Appendices\Space\05120400.svg
svg\Appendices\Atmospheric\45162101.svg
svg\Legacy\2525C\S-G-UCDMM-_2.svg
svg\Legacy\2525C\S-G-UUMSEJ_0.svg
svg\Legacy\2525C\S-G-UUMSEJ_1.svg
svg\Legacy\2525C\S-G-UUMSEJ_2.svg
svg\Legacy\2525C\S-G-UUMSEJ_3.svg

There are still some drawing issues that we are looking at for:
svg\Appendices\Land\20120201.svg
svg\Appendices\Activities\40131202_0.svg
svg\Appendices\Activities\40131202_1.svg
svg\Appendices\Activities\40131202_2.svg
svg\Appendices\Activities\40131202_3.svg

Removing the empty path from the SVG is a good work around however, we do want to fix the issue in Pro as well.

@topowright-zz topowright-zz changed the title Using Pro 2.2, some of the 2525D Source SVGs are failing to import into Pro Styles Using Pro 2.3, some of the 2525D Source SVGs are failing to import into Pro Styles Sep 25, 2018
@topowright-zz
Copy link
Contributor Author

This issue was moved to ArcGIS/military-symbology-styles#31

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants