Add full support for Diagnostic.code

Updated the framework to have full support according to the VS Code API
EstFoisy · Oct 13, 2022 · 76d6d1a · 76d6d1a
1 parent 3794302
commit 76d6d1a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/plugin-ext/src/plugin/type-converters.spec.ts b/packages/plugin-ext/src/plugin/type-converters.spec.ts
@@ -449,12 +449,12 @@ describe('Type converters:', () => {
             assert.strictEqual(Converter.convertCode(undefined), undefined);
         });
         it('should convert a "code" of type "{ value: number, target: Uri }"', () => {
-            const Uri = types.URI.parse('foo://example.com:8042/over/there?name=ferret#nose');
-            assert.strictEqual(Converter.convertCode({ value: 4, target: Uri }), '4');
+            const uri = types.URI.parse('foo://example.com:8042/over/there?name=ferret#nose');
+            assert.strictEqual(Converter.convertCode({ value: 4, target: uri }), '4');
         });
         it('should convert a "code" of type "{ value: number, target: Uri }"', () => {
-            const Uri = types.URI.parse('foo://example.com:8042/over/there?name=ferret#nose');
-            assert.strictEqual(Converter.convertCode({ value: 'string', target: Uri }), 'string');
+            const uri = types.URI.parse('foo://example.com:8042/over/there?name=ferret#nose');
+            assert.strictEqual(Converter.convertCode({ value: 'string', target: uri }), 'string');
         });
     });
 });
diff --git a/packages/plugin-ext/src/plugin/type-converters.ts b/packages/plugin-ext/src/plugin/type-converters.ts
@@ -339,7 +339,7 @@ export function convertCode(code: string | number | { value: string | number; ta
     if (typeof code === 'string' || typeof code === 'undefined') {
         return code;
     } else {
-        return code = String(code.value);
+        return String(code.value);
     };
 }