From db76b1ba701f94148e4cc023debb8666358bbc20 Mon Sep 17 00:00:00 2001 From: Branislav Kojic Date: Fri, 26 Jan 2024 06:40:13 +0100 Subject: [PATCH] Minor fixes (#29) * Deploy Network * Add Permissions * Minor changes * Concurrency change * Destroy Network * Minor changes * Minor changes * Fix commit sha * Minor changes * Add Tests * Disable Tests temporarily * Nightly Build * Minor fixes * Big changes * Minor changes * Minor changes * Minor changes * Notification fixes * Notification changes * Minor changes * Permissions fixes * Minor changes * Notification changes * Minor changes * Display commit on notifications * Minor changes * Minor fixes * Logs notification fixes * Minor changes --- .github/workflows/nightly.yml | 1 + .github/workflows/notification-destroy-network.yml | 2 +- .github/workflows/notification-main.yml | 8 ++++++-- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index a3d2d59cda..cd3ac24ab5 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -110,6 +110,7 @@ jobs: if: success() || failure() with: environment: nightly + logs: false build_output: ${{ needs.build.outputs.workflow_output }} unit_test_output: ${{ needs.tests.outputs.unit-test }} e2e_polybft_test_output: ${{ needs.tests.outputs.e2e-polybft-test }} diff --git a/.github/workflows/notification-destroy-network.yml b/.github/workflows/notification-destroy-network.yml index 4c5c19c8fd..8219fd07c5 100644 --- a/.github/workflows/notification-destroy-network.yml +++ b/.github/workflows/notification-destroy-network.yml @@ -90,7 +90,7 @@ jobs: "type": "plain_text", "text": "${{ inputs.logs == true && inputs.destroy_network_upload_logs == '' && 'Logs' || 'No Logs' }}" }, - "style": "${{ inputs.destroy_network_upload_logs == '' && env.succeed_bnt || env.failed_bnt }}", + "style": "${{ inputs.logs == true && inputs.destroy_network_upload_logs == '' && env.succeed_bnt || env.failed_bnt }}", "url": "https://s3.console.aws.amazon.com/s3/buckets/${{ secrets.AWS_S3_BLADE_BUCKET }}?region=${{ vars.AWS_REGION }}&prefix=logs/${{ github.run_id }}/" } ] diff --git a/.github/workflows/notification-main.yml b/.github/workflows/notification-main.yml index 8d36ceae45..6d613ebcfa 100644 --- a/.github/workflows/notification-main.yml +++ b/.github/workflows/notification-main.yml @@ -7,6 +7,10 @@ on: # yamllint disable-line rule:truthy description: The environment to run against type: string required: true + logs: + description: Upload Logs + type: boolean + required: true build_output: description: Build output type: string @@ -135,9 +139,9 @@ jobs: "type": "button", "text": { "type": "plain_text", - "text": "${{ inputs.destroy_network_logs_output == '' && 'Logs' || 'No Logs' }}" + "text": "${{ inputs.logs == true && inputs.destroy_network_logs_output == '' && 'Logs' || 'No Logs' }}" }, - "style": "${{ inputs.destroy_network_logs_output == '' && env.succeed_bnt || env.failed_bnt }}", + "style": "${{ inputs.logs == true && inputs.destroy_network_logs_output == '' && env.succeed_bnt || env.failed_bnt }}", "url": "https://s3.console.aws.amazon.com/s3/buckets/${{ secrets.AWS_S3_BLADE_BUCKET }}?region=${{ vars.AWS_REGION }}&prefix=logs/${{ github.run_id }}/" } ]