Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverse color broken with WebGL #2210

Open
yurenchen000 opened this issue Mar 3, 2020 · 6 comments
Open

Inverse color broken with WebGL #2210

yurenchen000 opened this issue Mar 3, 2020 · 6 comments

Comments

@yurenchen000
Copy link

yurenchen000 commented Mar 3, 2020

use default color scheme,
tested backgroundcolor from theme or color scheme.

  • OS: win 10
  • ver: terminus-1.0.104-portable.zip

xterm (WebGL) //broken

image

image

xterm or hterm //correct appearance

image

image

@ChipwizBen
Copy link

I had this same problem. You need to set "Terminal background" to "From colour scheme".

@yurenchen000
Copy link
Author

yurenchen000 commented Mar 10, 2020

I had this same problem. You need to set "Terminal background" to "From colour scheme".

thanks for your rely.

I had try Terminal background: From colour scheme, result same.
I use the default color settings.

  colorScheme:
    name: Material
    foreground: '#eceff1'
    background: 'rgba(38, 50, 56, 1)'
    cursor: '#FFCC00'
    colors:
      - '#000000'
      - '#D62341'
      - '#9ECE58'
      - '#FAED70'
      - '#396FE2'
      - '#BB80B3'
      - '#2DDAFD'
      - '#d0d0d0'
      - 'rgba(255, 255, 255, 0.2)'
      - '#FF5370'
      - '#C3E88D'
      - '#FFCB6B'
      - '#82AAFF'
      - '#C792EA'
      - '#89DDFF'
      - '#ffffff'

dig again, found something,

seems xterm(webgl) doesn't render #000000 right

try with #000001 got some corrupt display:

image

try other color, #000010 seems fine:

image

seems xterm(webgl) doesn't render rgba alpha right

replace rgba(255, 255, 255, 0.2) with fix color #4d555d, seems fine:

image

@yurenchen000
Copy link
Author

yurenchen000 commented Mar 10, 2020

so a workaround, my settings change to:

     colors:
-      - '#000000'
+      - '#000010'
       - '#D62341'
       - '#9ECE58'
       - '#FAED70'
       - '#396FE2'
       - '#BB80B3'
       - '#2DDAFD'
       - '#d0d0d0'
-      - 'rgba(255, 255, 255, 0.2)'
+      - '#4d555d'
       - '#FF5370'
       - '#C3E88D'
       - '#FFCB6B'
       - '#82AAFF'
       - '#C792EA'
       - '#89DDFF'
       - '#ffffff'

@Eugeny Eugeny changed the title xterm (WebGL) seems color not right Inverse color broken with WebGL Mar 25, 2020
@Eugeny
Copy link
Owner

Eugeny commented Mar 25, 2020

This is an upstream issue that has been successfully fixed in the normal xterm renderer, but is still open in the WebGL one - xtermjs/xterm.js#1898

@sriramkandukuri
Copy link

Any update on this ?

Thanks,
Sriram.K

@Eugeny
Copy link
Owner

Eugeny commented May 25, 2021

Unfortunately not yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants