Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] incorrect color scheme after getting out of GNU/screen #779

Closed
Alex4386 opened this issue Apr 23, 2019 · 12 comments
Closed

[Bug Report] incorrect color scheme after getting out of GNU/screen #779

Alex4386 opened this issue Apr 23, 2019 · 12 comments

Comments

@Alex4386
Copy link

Shell: bash
local Platform: macOS 10.14.4 (Mojave)
Steps to reproduce:

  1. create a screen with screen -S screenName
  2. terminate screen with exit
  3. The color schemes are strange.

Same Applies to Ubuntu 18.04.2 LTS with Secure Shell Connection.

@Alex4386
Copy link
Author

Alex4386 commented Apr 23, 2019

Providing Image for troubleshooting:
image
What is wrong?
ls (cmdline input) is having the wrong color. That should be white and not bold.

@Alex4386
Copy link
Author

Alex4386 commented Apr 28, 2019

Update: Provided Bug is not caused in Build 73 (which uses xterm 3.10.2), Which was the last build before the update.
image

Likely Update to Build 75 caused this issue.

@Alex4386
Copy link
Author

Alex4386 commented Apr 29, 2019

Update: Downgrading Xterm.js to 3.12.2 fixed this issue.
This bug is related to xterm, Closing issue for now.

@Tyriar
Copy link
Contributor

Tyriar commented Apr 29, 2019

@Eugeny @Alex4386 were you on xterm@3.13.0-beta1 when this repro'd?

@Tyriar
Copy link
Contributor

Tyriar commented Apr 29, 2019

Oh nevermind, I saw beta2 in the xterm report. Thanks 😃

@Eugeny
Copy link
Owner

Eugeny commented Apr 29, 2019

I'll keep this open - otherwise I'll forget to recheck this when 3.13 is released

@Tyriar
Copy link
Contributor

Tyriar commented Apr 29, 2019

@Eugeny thanks for trying out the beta build, the reports are extremely helpful 🙂

@Eugeny
Copy link
Owner

Eugeny commented Apr 29, 2019

@Tyriar you're welcome, can't wait for the webgl renderer to get released! :) I'm going to roll back to 3.12 in the next release though, the Unicode char coloring bug is too much for the users.

@Tyriar
Copy link
Contributor

Tyriar commented Apr 29, 2019

@Eugeny understandable.

Yeah I'm having trouble finding time to finish the webgl renderer off, the problem is it has quite a lot of pre-requisites due to the decision not to include it in core (primarily xtermjs/xterm.js#2005, xtermjs/xterm.js#1128). It also just broke because of the UTF32 changes and will need some a little updating to support true color (:tada:).

@Alex4386
Copy link
Author

Alex4386 commented Apr 30, 2019

@Tyriar
Yes, It was reproduced in xterm 3.13.0-beta1 (which is this repo does in package.json),
Since It was not up-to-date, I manually updated to 3.13.0-beta2 and checked, and since the bugs are reproduced and I found out this was xterm issue (since this is non-existent bugs at 3.12.2), and created issue at xtermjs/xterm.js#2030

@jerch
Copy link

jerch commented May 5, 2019

Any idea how this can be repro'ed with xterm.js demo? Note that for me the prompt correctly changes colors for screen, also reliable for detaching/reattaching (from some greenish thing to blue/red prompt).

@Eugeny
Copy link
Owner

Eugeny commented Feb 29, 2020

Has been fixed in xterm since.

@Eugeny Eugeny closed this as completed Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants