Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to clampChroma option to clamp to P3 space #168

Closed
ai opened this issue May 3, 2022 · 3 comments · Fixed by #199
Closed

Add to clampChroma option to clamp to P3 space #168

ai opened this issue May 3, 2022 · 3 comments · Fixed by #199

Comments

@ai
Copy link

ai commented May 3, 2022

P3 space is widely used (any modern Apple tech) and give a lot of new color.

We are using clampChroma to generate dynamic accent color. It would be nice to be able to clamp chroma not just to fit sRGB, but also to fit P3.
@danburzo
Copy link
Collaborator

danburzo commented Jun 8, 2022

Hi @ai, thanks for the suggestion and sorry for the late response. This feature is captured in the PR:

It introduces more generic functions for clampChroma, clampRGB, and displayable.

@ai
Copy link
Author

ai commented Jun 8, 2022

Cool! But this PR will break TypeScript PR.

Can we merge TS first? TS is very important for modern days DX.

@danburzo
Copy link
Collaborator

Although initially planned for #165, the PR does not include an implementation of toGamut(), which this feature request is concerned with.

Some references on the topic:

@danburzo danburzo mentioned this issue Mar 26, 2023
Merged
@antiflasher antiflasher mentioned this issue Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement toGamut() Evercoder/culori
2 participants
@ai @danburzo