Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweight specialization on FixedPoint #39

Closed
johnnychen94 opened this issue Jan 29, 2020 · 1 comment
Closed

tweight specialization on FixedPoint #39

johnnychen94 opened this issue Jan 29, 2020 · 1 comment
Labels
Milestone

Comments

@johnnychen94
Copy link
Collaborator

johnnychen94 commented Jan 29, 2020

some tests in tst_rotation.jl are broken because the inferred weight type is incorrect. This might be due to recent upgrades in Interpolation and FixedPointNumbers.

julia> img = Gray{N0f8}[0.1 0.2 0.3; 0.4 0.5 0.6; 0.7 0.6 0.9];

julia> Augmentor.applyeager(Rotate(90), img); # eltype Gray{N0f8}

julia> Augmentor.applyeager(Rotate(90), N0f8.(img)); # eltype Float64 # not expected

A quick fix can be found in JuliaImages/ImageTransformations.jl#89 , but in the meantime, we need another patch in Augmentor to keep backward compatibility to old ImageTransformation versions.

@johnnychen94
Copy link
Collaborator Author

closed by #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant