Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] SearchingEvent #2324

Closed
louis1706 opened this issue Dec 12, 2023 · 4 comments · Fixed by #2311
Closed

[BUG] SearchingEvent #2324

louis1706 opened this issue Dec 12, 2023 · 4 comments · Fixed by #2311
Labels
bug Something isn't working P3 Low Priority

Comments

@louis1706
Copy link
Member

Describe the bug
Exiled make unable to change the searching time for pickup

To Reproduce
Steps to reproduce the behavior:

  1. Use NW event to modify the time to search a pickup
  2. it's do not work if exiled SearchingPickupEvent is used (transpiler)

Expected behavior
Exiled should not impact on how NWEvent work

@louis1706 louis1706 added bug Something isn't working P3 Low Priority labels Dec 12, 2023
@louis1706 louis1706 changed the title [ISSUE] SearchingEvent [BUG] SearchingEvent Dec 12, 2023
@VALERA771
Copy link
Contributor

Can't find NW event where we can change this. Can you name it pls cuz maybe patch method problem

@louis1706
Copy link
Member Author

louis1706 commented Dec 13, 2023

Can't find NW event where we can change this. Can you name it pls cuz maybe patch method problem

Plugin was modifying the Weight of the item (to modify the time of Searching) and nw event is call when whe use this searchCompletor.ValidateStart()
in base game ValidateStart is call before request.Target.SearchTimeForPlayer(Hub) but Exiled make it call after

also we don't need to remove the first line of code and we can keep IsAllowed as always true

@louis1706
Copy link
Member Author

#2311 my original PR but i have need to abandon it since my computer broke

@VALERA771
Copy link
Contributor

Not reproducible

@NaoUnderscore NaoUnderscore added the invalid This doesn't seem right label Dec 31, 2023
@louis1706 louis1706 removed the invalid This doesn't seem right label Jan 25, 2024
@louis1706 louis1706 linked a pull request Feb 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P3 Low Priority
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants