Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [DynamicEvents] Scp914.UpgradingInventoryItem event does not fire unless Scp914.UpgradingPlayer is subscribed. #2452

Closed
o5zereth opened this issue Feb 10, 2024 · 1 comment · Fixed by #2455
Closed

[BUG] [DynamicEvents] Scp914.UpgradingInventoryItem event does not fire unless Scp914.UpgradingPlayer is subscribed. #2452

o5zereth opened this issue Feb 10, 2024 · 1 comment · Fixed by #2455
Assignees
@louis1706
Labels
bug Something isn't working

Comments

@o5zereth
Copy link

Simply subscribing to the Scp914.UpgradingInventoryItem event is not sufficient to receive it properly.
The harmony patch involved with firing this event is only attached to the Scp914.UpgradingPlayer event, and requires that it be subscribed to as well before Scp914.UpgradingInventoryItem can be fired as intended.
@o5zereth o5zereth changed the title [DynamicEvents] Scp914.UpgradingInventoryItem event does not fire unless Scp914.UpgradingPlayer is subscribed. [BUG] [DynamicEvents] Scp914.UpgradingInventoryItem event does not fire unless Scp914.UpgradingPlayer is subscribed. Feb 10, 2024
@louis1706 louis1706 added the bug Something isn't working label Feb 14, 2024
@louis1706 louis1706 linked a pull request Feb 14, 2024 that will close this issue
[Fix] [DynamicEvents] Scp914.UpgradingInventoryItem event does not fire unless Scp914.UpgradingPlayer is subscribed #2455
Merged
@louis1706
Copy link
Member

Thanks for the Information next release will contain the fix (for now you can get the build directly from github) on #2455

@louis1706 louis1706 assigned louis1706 and unassigned o5zereth Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louis1706 louis1706

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@louis1706 @o5zereth