-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency of make version_test/unit-test/bash_tests on bash #1274
Comments
Sorry, I still don't know about unit_test and version_test. version_test \
unit_test :
@echo
@echo ---- Running $@ ----
@echo
-@./$@.sh Or rewrite the test cases named version_test.py and unit_test.py? |
I think running unit_test from python is a couple of lines on python and version_test is one line of python! make unit_test
Today, it runs some bash code: 1081 rmills@rmillsm1:~/gnu/github/exiv2/0.27-maintenance/build $ cat ../test/unit_test.sh
#!/usr/bin/env bash
# driver for $ make unit_test
( source ./functions.source ; runTest unit_tests --gtest_color=no 2>&1 | grep -v "Warning: Unsupported .... format" )
# That's all Folks!
## Can you get make version_test Every build of exiv2 command-line program supports options
You'll do this easily when you understand what I'd like you to do! Remember the aim. We want bash out of the code base. Gone. Unix users will run the test suite with command such as: $ cd build
$ make tests
$ make version_test etc.... msvc developers will use: $ cd build
$ cmake --build . --target tests
$ cmake --build . --target version_test etc... Both those command execute |
Oh oh, I won't have time to finish it this weekend. |
That's fine. I'm going to release Exiv2 v0.27.4 RC1 this week. We are two weeks ahead of schedule. Code freeze/RC2 is scheduled for 2021-04-30. However it would be very helpful if you could complete this in March and we arrive at Code Freeze in Early April. |
Closed by #1495 |
After #1257 is merged, we can now move rapidly to remove the last vestiges of bash in the test suite.
Currently the commands in the build directory use bash to run different parts of the test suite.
Remove the dependency on bash. In #1257, you are running the new bash_tests from python. Let's give similar treatment to unit_test and version_test.
Please prepare the PR for v0.27-maintenance. We'll have to update README.md (and possibly README-CONAN.md) to match the code. I'll give you those changes as part of the PR review.
There is no plan yet to adopt #1257 and other python test enhancements into 'master'.
We've had an offer from @kmilos to help test this on MinGW/msys2. Thank You, @kmilos. I'll get GitHub to invite you to join Team Exiv2 and I will add you to the assignees for this issue and subsequent PR. I won't dump work on @kmilos unless he volunteers for other issues.
The text was updated successfully, but these errors were encountered: