feat(deps): pydantic 1.x.x to 2.x.x migration
#292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 3, 2023 22:10
Unnecessary dependencies removed from the `requirements-dev.txt` file and moved into a newly created `requirements-test.txt` file. Also, redundant imports in `test_api_client.py` have been removed. This refactoring was done to segregate development and testing dependencies, enhancing maintainability.
Unnecessary dependencies removed from the `requirements-dev.txt` file and moved into a newly created `requirements-test.txt` file. Also, redundant imports in `test_api_client.py` have been removed. This refactoring was done to segregate development and testing dependencies, enhancing maintainability.
Added detailed descriptions and examples of usage in the docstring for the `RequestHeaders` class and its method `unwrap` in `model/api.py`. These additions aim to provide clearer insights into the role of the class and its method, enhancing readability and facilitating the developers' understanding.
Changed the import statement of ValidationError from 'from pydantic.error_wrappers import ValidationError' to 'from pydantic import ValidationError' in test_pydantic_model.py. This change makes the import more general and less dependent on the internal structure of the pydantic library.
Added an empty line at the end of the class docstring field in `expediagroup/sdk/core/model/api.py`. This improves readability without altering functionality or structure of the codebase.
Removed a debugging print statement from the datatype_manager.py file. This was an artifact left behind from testing, and its removal does not affect functionality but reduces unnecessary console output during execution.
mohnoor94
requested changes
Dec 4, 2023
mohnoor94
previously approved these changes
Dec 4, 2023
mohnoor94
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Related Issues