From 5364229aed4a7c126337376781b806c3bd58357a Mon Sep 17 00:00:00 2001 From: Vit Horacek Date: Thu, 6 Jul 2023 12:39:23 -0500 Subject: [PATCH 1/3] Do not use the replace in case of RHP as its fixing edge case --- src/libs/Navigation/linkTo.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/libs/Navigation/linkTo.js b/src/libs/Navigation/linkTo.js index c86c15c38146..4b8a0c90bd6f 100644 --- a/src/libs/Navigation/linkTo.js +++ b/src/libs/Navigation/linkTo.js @@ -79,12 +79,8 @@ export default function linkTo(navigation, path, type) { } if (action.payload.name === NAVIGATORS.RIGHT_MODAL_NAVIGATOR) { - const {minimalAction, targetName} = getMinimalAction(action, navigation.getRootState()); + const {minimalAction} = getMinimalAction(action, navigation.getRootState()); if (minimalAction) { - // If the target name is RHP that means this action is responsible for changing flow within the RHP e.g. from settings to search. In that case we want to use REPLACE. - if (targetName === NAVIGATORS.RIGHT_MODAL_NAVIGATOR) { - minimalAction.type = 'REPLACE'; - } root.dispatch(minimalAction); return; } From e41243a1da0e424b7080c3bcf505b51feb68ccad Mon Sep 17 00:00:00 2001 From: Vit Horacek Date: Thu, 6 Jul 2023 14:11:43 -0500 Subject: [PATCH 2/3] Refactor the getMinimalAction as we dont need targetName anymore --- .../AppNavigator/Navigators/RightModalNavigator.js | 10 +++++++++- src/libs/Navigation/AppNavigator/RHPScreenOptions.js | 2 +- src/libs/Navigation/linkTo.js | 9 +++------ 3 files changed, 13 insertions(+), 8 deletions(-) diff --git a/src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.js b/src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.js index 7b22475bc623..116e54e6001b 100644 --- a/src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.js +++ b/src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.js @@ -17,13 +17,21 @@ function RigthModalNavigator() { name="NewChat" component={ModalStackNavigators.NewChatModalStackNavigator} /> - Date: Thu, 6 Jul 2023 14:26:46 -0500 Subject: [PATCH 3/3] Fix linter --- .../Navigation/AppNavigator/Navigators/RightModalNavigator.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.js b/src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.js index 116e54e6001b..a04e9bfc10ec 100644 --- a/src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.js +++ b/src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.js @@ -17,7 +17,7 @@ function RigthModalNavigator() { name="NewChat" component={ModalStackNavigators.NewChatModalStackNavigator} /> -