diff --git a/src/libs/actions/IOU.ts b/src/libs/actions/IOU.ts index 4c722f32d4c6..b90017b7b922 100644 --- a/src/libs/actions/IOU.ts +++ b/src/libs/actions/IOU.ts @@ -892,15 +892,15 @@ function buildOnyxDataForMoneyRequest( }); } - const {optimisticData: fieldViolationsOptimisticData, failureData: fieldViolationsFailureData} = getFieldViolationsOnyxData(iouReport); - optimisticData.push(...fieldViolationsOptimisticData); - failureData.push(...fieldViolationsFailureData); - // We don't need to compute violations unless we're on a paid policy if (!policy || !PolicyUtils.isPaidGroupPolicy(policy)) { return [optimisticData, successData, failureData]; } + const {optimisticData: fieldViolationsOptimisticData, failureData: fieldViolationsFailureData} = getFieldViolationsOnyxData(iouReport); + optimisticData.push(...fieldViolationsOptimisticData); + failureData.push(...fieldViolationsFailureData); + const violationsOnyxData = ViolationsUtils.getViolationsOnyxData( transaction, [], @@ -1595,17 +1595,17 @@ function buildOnyxDataForTrackExpense( }, ); + // We don't need to compute violations unless we're on a paid policy + if (!policy || !PolicyUtils.isPaidGroupPolicy(policy)) { + return [optimisticData, successData, failureData]; + } + if (iouReport) { const {optimisticData: fieldViolationsOptimisticData, failureData: fieldViolationsFailureData} = getFieldViolationsOnyxData(iouReport); optimisticData.push(...fieldViolationsOptimisticData); failureData.push(...fieldViolationsFailureData); } - // We don't need to compute violations unless we're on a paid policy - if (!policy || !PolicyUtils.isPaidGroupPolicy(policy)) { - return [optimisticData, successData, failureData]; - } - const violationsOnyxData = ViolationsUtils.getViolationsOnyxData( transaction, [],