Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to NPM 8 and Node 16 #10331

Closed
AndrewGable opened this issue Aug 9, 2022 · 3 comments
Closed

Update to NPM 8 and Node 16 #10331

AndrewGable opened this issue Aug 9, 2022 · 3 comments
Assignees
@AndrewGable
Labels
Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@AndrewGable
Copy link
Contributor

Problem

We have countless issues running npm 6 and npm 14:

  • Issues running on M1 machines
  • Issues upgrading react native versions

Solution

Update internally and this codebase to run on NPM 8 and Node 16.
@AndrewGable AndrewGable added Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff labels Aug 9, 2022
@AndrewGable AndrewGable self-assigned this Aug 9, 2022
@AndrewGable
Copy link
Contributor Author

Here is my first attempt at doing this: #9867

However, this PR got way to large, so I am going to instead break this PR up into smaller chunks.

@AndrewGable AndrewGable mentioned this issue Aug 9, 2022
Merged
@parasharrajat
Copy link
Member

Long awaited change. Thanks

@AndrewGable AndrewGable mentioned this issue Aug 18, 2022
Merged
46 tasks
@AndrewGable AndrewGable added the Reviewing Has a PR in review label Aug 18, 2022
@AndrewGable
Copy link
Contributor Author

PR in review

@melvin-bot melvin-bot bot closed this as completed Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewGable AndrewGable

Labels
Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndrewGable @parasharrajat