Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update react-dom #10411

Closed
luacmartins opened this issue Aug 16, 2022 · 1 comment
Closed

Update react-dom #10411

luacmartins opened this issue Aug 16, 2022 · 1 comment
Assignees
@luacmartins
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

Problem

We updated React to v18, but react-dom was not updated, this is causing issues with Storybook.

Why is this important

Keeps our dependencies up-to-date and allows us to use storybook to develop components.

Solution

Update react-dom to v18
@luacmartins luacmartins self-assigned this Aug 16, 2022
@luacmartins luacmartins added the Internal Requires API changes or must be handled by Expensify staff label Aug 16, 2022
@luacmartins luacmartins mentioned this issue Aug 16, 2022
Closed
93 tasks
@luacmartins luacmartins added Weekly KSv2 and removed Daily KSv2 labels Aug 17, 2022
@luacmartins
Copy link
Contributor Author

We are updating react-dom here. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luacmartins luacmartins

Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luacmartins