Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-09-16 #11043

Closed
27 tasks done
OSBotify opened this issue Sep 16, 2022 · 8 comments
Closed
27 tasks done

Deploy Checklist: New Expensify 2022-09-16 #11043

OSBotify opened this issue Sep 16, 2022 · 8 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Sep 16, 2022

Release Version: 1.2.1-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Sep 16, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.1-0 🚀

@mountiny
Copy link
Contributor

Checking #11044 (comment) off as we have updated the servers config and all works now.

@luacmartins
Copy link
Contributor

Checking #11058 off since it's on prod.

@francoisl
Copy link
Contributor

francoisl commented Sep 16, 2022

Thanks, with that I'm going to check #10974 which is passing for me.

@mvtglobally this means we just have these three PRs left that need to be QAed:

@mvtglobally
Copy link

Regression is completed

PR #10468 is failing due to #11058. We were not able to see in PROD, but since the blocker is removed, are we ok to check it off?
PR #10838 is failing due to #11068. Its also in PROD, so checking off

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 19, 2022
@luacmartins luacmartins self-assigned this Sep 19, 2022
@luacmartins
Copy link
Contributor

I tested #10468 on all platforms and it's a pass. Checking it off.

@luacmartins
Copy link
Contributor

  • API timings seem normal
  • Started a thread for a new Crashlytics error. We are deploying, since it's only one crash potentially related to a new feature we are still developing and we have an issue to investigate it.

@luacmartins
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants