Deploy Checklist: New Expensify 2022-11-15

[OSBotify]

Release Version: 1.2.28-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Fix emoji offset issues #8902
• fix: reset image viewer grabbed state when mouse is released #12226
• Add splash screen on web and desktop #12334
• Only update IOU total when network is online and the request currency matches the IOUReport's #12488
• Fix for: mWeb - Firefox - when you open a picker for the first time the popover blinks #12500
• Fix/12005: Settings navigation modal leaves empty space at the bottom #12509
• Tooltip gets stuck on the page fix #12572
• fix/11688: when deleting the last message, the chat is marked as unread for a moment #12583
• Fix for: mWeb- Blank page is displayed when tapped on Concierge or Send a message options #12588
• disable text selection #12593
• mWeb/Chrome - Account Management page - Required section name is not visible #12601
• fix scroll speed of InvertedFlatList #12602
• remove hyperlink functionality #12610
• Custom h1 tag style to make custom subject messages look nicer. #12619
• [NO QA] Adding instruction to not engage with the onboarding team to the readme file #12657
• [Fix] Composer text and icon not aligned center vertically for native app #12669
• Fix unclickable context menu #12677
• Pass array to navigateToAndOpenReport instead of string #12679
• Remove unnecessary shouldRemoveClippedSubviews prop #12686
• Remove renderCell method as it's no longer needed and causes errors #12688
• update structure Send money #12695
• update The Free Plan article #12697
• [NoQA] Bump expensify-common version #12702
• Reverts elements from #12169 #12722
• [NoQA] Update the comment about the max attachment size #12738
• [NoQA] Smarter regex for parsing No QA PRs #12754
• Splash Web - Fix mapping of production logo and do work only after DOM is ready #12785

Internal QA:

• Have GitHub Actions check the new reviewer checklist #12429 - @tgolen @arosiclair

Deploy Blockers:

• [HOLD for payment 2022-11-24] [$250] Desktop - Blank screen is displayed after update to new build 1.2.28-0 #12760

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.28-0 🚀

[dangrous]

Working on internal QA for #12429 - we may need some edits - I've posted a comment on the PR.

[arosiclair]

Thanks for taking over QA on that one. Just saw this now

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.28-1 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.28-1 has been deployed to staging 🎉

[mvtglobally]

@roryabraham We are blocked on Desktop due to #12760

[roryabraham]

A fix for #12760 is being CP'd to staging presently

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.28-2 🚀

[roryabraham]

#12785 has been deployed on all platforms except iOS, so you should be able to retest #12760 at any time and resume regressions

[mvtglobally]

thanks @roryabraham we will resume

[roryabraham]

Confirmed #12760 is resolved, checking it off

[mvtglobally]

Regression is completed

PR #12226 is failing #12777. Repro in PROD
PR #12334 is failing #12789. Repro in PROD
PR #12488 is failing #12779 & #12792. Repro in PROD
PR #12572 doesn't have tooltip on mweb and Native aps. Pass on Desktop/Web. Ok to checkoff?
PR #12588 is blocked by #12776
PR #12601 #12695 & #12697 are PROD QA of Help pages. Ok to check off?
PR #12785 is god on Desktop. checking other platforms just in case

[roryabraham]

• Checked off Tooltip gets stuck on the page fix #12572
• Fix for: mWeb- Blank page is displayed when tapped on Concierge or Send a message options #12588 isn't relevant because that flow isn't accessible due to [Hold for Payment: 2022-12-09] [$250] LHN - Opening <EXPENSIFY_URL>/concierge, system redirected to LHN #12776

PR #12601 #12695 & #12697 are PROD QA of Help pages. Ok to check off?

While they are PROD QA, keep in mind that help pages are deployed immediately so can be QA'd at any time. Usually this will be very quick so for now while we don't have a prodQA checklist we should just do them during the main checklist. There's also no scenario where we'd have a help site deploy blocker, so there's not much risk involved with these..

#12785

Confirmed myself that this works so we should be good to check it off.

• Have GitHub Actions check the new reviewer checklist #12429 doesn't work perfectly but we do not need to block deploy since the code for the workflow runs from main anyways we can fix it regardless of the release cycle. I know that @tgolen and @dangrous are investigating. Checking it off to proceed with the deploy.

[roryabraham]

I am seeing a spike in homepage initial render, but it seems probably that this could be attributed to the process change ensuring that people test on high traffic accounts.

[roryabraham]

There is a new crash too, but I think it's only happening in UIAutomator, which unless I'm mistaken is only related to E2E automated tests, which aren't live yet.

[roryabraham]